From 4e174891c7d84768a1f76e1efbf953193974f5d3 Mon Sep 17 00:00:00 2001
From: Peter Mounce <petermounce@improbable.io>
Date: Tue, 26 Mar 2019 15:26:24 +0000
Subject: [PATCH] ENG-1281: trigger.sh is no longer necessary.

ENG-1281 replaces trigger.sh with `imp-ci steps run --from ...steps.yaml`.

If, after this deletion, your pipeline fails to run, you should:

```bash
cd {repo-root}
circle ci pipeline push -n {name}
```

and retry, because (apologies) I must have missed it when I bulk-updated pipelines in BuildKite.

The pipeline definition _within the buildkite pipeline settings page_ should resemble:

```yaml
steps:
- agents:
  - environment=production
  - queue=trigger-pipelines
  command: imp-ci steps run --from .buildkite/premerge.steps.yaml
  label: premerge
  retry:
    automatic:
    - exit_status: -1
      limit: 3
  timeout_in_minutes: 10
- wait: wait-for-steps-upload
```

The two differences that my change makes are
* ENG-1281: the change to the command step from `.buildkite/trigger.sh {name}.steps.yaml` to `imp-ci steps run --from {name}.steps.yaml`
* ENG-1450: the addition of the `- wait: wait-for-steps-upload` _after_ the `command` step (to eliminate a race condition when cancelling a pipeline).
---
 .buildkite/trigger.sh | 12 ------------
 1 file changed, 12 deletions(-)
 delete mode 100755 .buildkite/trigger.sh

diff --git a/.buildkite/trigger.sh b/.buildkite/trigger.sh
deleted file mode 100755
index f45a844..0000000
--- a/.buildkite/trigger.sh
+++ /dev/null
@@ -1,12 +0,0 @@
-#!/usr/bin/env bash
-# https://brevi.link/shell-style
-# https://explainshell.com
-set -euo pipefail
-if [[ -n "${DEBUG-}" ]]; then
-  set -x
-fi
-cd "$(dirname "$0")/../"
-
-# The step-definitions file is uploaded dynamically to preserve ability for historical builds
-# vs changes in CI pipeline configuration.
-buildkite-agent pipeline upload "$1"