Update to Commonmark v2 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is awesome, I'll review it soon. I you feel up to it, you could send a similar PR to our commonmark-shiki-highlighter package, which provides superior highlighting. |
Member
|
@alexanderglueck could you make those failing tests pass by updating the versions of requirements of the package? |
Contributor
Author
|
I increased the minimum required version of highlight.php to 9.18.1.7 and now the tests are only failing (on my branch) due to not being able to push to Scrutinizer. |
Member
|
@alexanderglueck running the tests... 🤞 |
Member
|
All good 🙌 |
Member
|
Thank you! |
Contributor
Author
|
You're welcome. Just one more quick question, when can I expect a release so I can change my project to pull in the new version? 😄 |
Member
|
You can expect it in... one minute. |
Contributor
Author
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes commonmark-highlighter compatible with league/commonmark v2. By upgrading to v2, support for v1 is dropped. This is a breaking change, and therefor I marked the release in the changelog as 3.0.
Changes:
Changes to tests:
highlight.php produces different output depending on the installed version:
I updated the tests to use the newly generated output. However, now testing for "prefer-lowest" fails because .4 is installed instead of .7.
I am looking forward to suggestions on how I can fix this tricky situation (fixtures).
TLDR on tests: highlight.php 9.18.1.4 generates different output than 9.18.1.7. I updated the fixtures to work with the latest version. Tests fail because of prefer-lowest.
Closing
Let me know if there is anything else you need.