Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getFullUrl() is generating an incorrect URL for Arabic characters #1451

Closed
mkwsra opened this issue May 21, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@mkwsra
Copy link

commented May 21, 2019

I spent some time in order to figure out the problem and the matter, in fact, it's not related directly to Laravel Media Library, it's PHP mentality.

in vendor/spatie/laravel-medialibrary/src/UrlGenerator/BaseUrlGenerator.php:82:5, the pathinfo() function is affected by PHP's setlocale(), and with default settings, it's slicing a portion of the URL as shown below:

Screen Shot 2019-05-20 at 6 35 42 PM

And after adding the proper Locale:
Screen Shot 2019-05-21 at 12 26 56 PM

So perhaps there is a plan to tweak this function or another solution to implement? any help is appreciated.

@freekmurze

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

If there's an easy, testable fix for us to implement, feel free to send a PR.

@freekmurze freekmurze closed this Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.