Add test for scope filter fix

spatie · May 25, 2020 · 2737b22 · 2737b22
1 parent b3fba93
commit 2737b22
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes to `laravel-query-builder` will be documented in this file
 
+## 2.8.2 - 2020-05-25
+
+- fix scope filters that are added via macros (e.g. `onlyTrashed`) (#469)
+
 ## 2.8.1 - 2020-03-20
 
 - make service provider deferrable (#381)

diff --git a/tests/FiltersTrashedTest.php b/tests/FiltersTrashedTest.php
@@ -46,6 +46,19 @@ public function it_can_filter_only_trashed()
         $this->assertCount(1, $models);
     }
 
+    /** @test */
+    public function it_can_filter_only_trashed_by_scope_directly()
+    {
+        $models = $this
+            ->createQueryFromFilterRequest([
+                'only_trashed' => true
+            ])
+            ->allowedFilters(AllowedFilter::scope('only_trashed'))
+            ->get();
+
+        $this->assertCount(1, $models);
+    }
+
     /** @test */
     public function it_can_filter_with_trashed()
     {