Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ShouldQueue interface #23

Open
Gummibeer opened this issue Feb 10, 2020 · 3 comments
Open

add support for ShouldQueue interface #23

Gummibeer opened this issue Feb 10, 2020 · 3 comments

Comments

@Gummibeer
Copy link

@Gummibeer Gummibeer commented Feb 10, 2020

The ShouldQueue interface is a laravel common to tell the queueable class to queue itself as normal behavior.
It would be great if this packages supports this interface and queues actions called via execute() only if the class implements this interface.

@freekmurze

This comment has been minimized.

Copy link
Member

@freekmurze freekmurze commented Feb 10, 2020

Good idea, I welcome a PR that adds this to the package.

@Gummibeer

This comment has been minimized.

Copy link
Author

@Gummibeer Gummibeer commented Feb 10, 2020

@freekmurze after thinking about it this was a quick blindshot. I have no idea how we should be able to override the execute() method from within the trait and call the original execute() method on the action class? :/

The only thing I could imagine would be a new method like run() that calls execute() or onQueue()->execute().

@larsjanssen6

This comment has been minimized.

Copy link

@larsjanssen6 larsjanssen6 commented Feb 24, 2020

@Gummibeer onQueue()->execute() already exists. Maybe ->executeOnQueue() would be better then onQueue()->execute()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.