Add Laravel 11 Support #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the tests are failing, could you take a look? |
|
@freekmurze yeah, because it depends on spatie/crawler, which is not compatible with Laravel 11 yet. (See the linked PR in the description) |
|
Crawler has been tagged, I'll rerun the tests. |
|
While the tests are passing: It seems like there are 5 missing snapshots, which are generated during the workflow run. I can generate 3 on my own laptop, but the other two need the test server. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds the option to install
nesbot/carbon@v3.Depends on spatie/crawler#461