use assertions in callables

spatie · Jun 24, 2019 · 60bd1b1 · 60bd1b1
1 parent 382c076
commit 60bd1b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/tests/IntegrationTest.php b/tests/IntegrationTest.php
@@ -44,11 +44,10 @@ public function it_can_handle_a_valid_request()
         $this->assertNull($webhookCall->exception);
 
         Event::assertDispatched('stripe-webhooks::my.type', function ($event, $eventPayload) use ($webhookCall) {
-            if (! $eventPayload instanceof WebhookCall) {
-                return false;
-            }
+            $this->assertInstanceOf(WebhookCall::class, $eventPayload);
+            $this->assertEquals($webhookCall->id, $eventPayload->id);
 
-            return $eventPayload->id === $webhookCall->id;
+            return true;
         });
 
         $this->assertEquals($webhookCall->id, cache('dummyjob')->id);

diff --git a/tests/StripeWebhookCallTest.php b/tests/StripeWebhookCallTest.php
@@ -68,11 +68,10 @@ public function it_will_dispatch_events_even_when_no_corresponding_job_is_config
         $webhookCall = $this->webhookCall;
 
         Event::assertDispatched("stripe-webhooks::{$webhookCall->payload['type']}", function ($event, $eventPayload) use ($webhookCall) {
-            if (! $eventPayload instanceof WebhookCall) {
-                return false;
-            }
+            $this->assertInstanceOf(WebhookCall::class, $eventPayload);
+            $this->assertEquals($webhookCall->id, $eventPayload->id);
 
-            return $eventPayload->id === $webhookCall->id;
+            return true;
         });
 
         $this->assertNull(cache('dummyjob'));