Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove illuminate/support dependency #18

Open
sebastiandedeyne opened this issue Sep 4, 2019 · 2 comments

Comments

@sebastiandedeyne
Copy link
Member

commented Sep 4, 2019

We're using illuminate/support for the Arr::get method. It's not worth pulling in this dependency for that, as every Laravel upgrade forces us to allow the newer version.

@IvanBernatovic

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

Hi, I'm interested in making a PR for this. The easiest approach is to copy Arr class and to strip it down only to the necessary methods so the get method can work properly. What do you think?

@freekmurze

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.