Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Abstract DPDK dependences with SPDK env APIs - Take 2 #136
- added SPDK_MAX_LCORE to abstract RTE_MAX_LCORE - added addtional spdk_lcore routines to env.c - removed rte_config and rte_lcore dependencies from reactor.c, bdev.c and app.c
- added SPDK_MEMPOOL_CACHE_MAX_SIZE to abstract RTE_MEMPOOL_CACHE_MAX_SIZE - added spdk_mempool_avail_count and moved rte version specific code into env layer - converted bdev.c to use spdk_mempool abstractions - small formatting changes in reactor.c
Thanks for your comments Ranjit I’ve cc’d Daniel and others. John Meneghini email@example.com…
On Apr 26, 2017, at 3:03 AM, Ranjit Noronha ***@***.***> wrote: @ranjitnoronha commented on this pull request. In include/spdk/env.h <#136 (comment)>: > +int +spdk_get_lcore_state(unsigned lcore_id); + +/** + * Send a message to a slave lcore identified by slave_id to call a + * function f with argument arg. Once the execution is done, the + * remote lcore switch in FINISHED state. + */ +int +spdk_remote_launch(int (*f)(void *), void *arg, unsigned slave_id); + +/** + * Memcpy + */ +void +spdk_memcpy(void *dst, const void *src, int len); I agree. We also need our own version of memcpy(). Calling rte_memcpy() irrespective of its internal optimizations does not work for us. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#136 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMVL3Snwf3KHJCB1YFaodJofO5a5jCFPks5rzuw8gaJpZM4M5pnY>.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.