Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract and move rte_ functions into spdk functions that act ad pass-through functions in env_dpdk #142

Closed
wants to merge 2 commits into from

Conversation

@ranjitnoronha
Copy link

ranjitnoronha commented Apr 17, 2017

Since the SPDK code is littered with references to rte_ functions, this make moving SPDK to another infrastructure provider from DPDK cumbersome.

Here, I have attempted to encapsulate the rte_ reference with spdk functions/references, and then implement the spdk functions as pass-through functions in env_dpdk.

This will make implementation of SPDK over another infrastructure provider simpler.

Signed-off-by: Ranjit Noronha <ranjit.noronha@oracle.com>
Signed-off-by: Ranjit Noronha <ranjit.noronha@oracle.com>
Copy link
Contributor

johnmeneghini left a comment

Hi Ranjit.

Some of these changes conflict with the changes in my pull requests at: #136
#148
#150

As you can see, I've refactored my pull request several times, and I have many more commits waiting to go in.

I spoke to Ben about this last week and I think our changes percipitated Ben's email on the reflector. Let's see if we can work together to get these changes in.

@ranjitnoronha
Copy link
Author

ranjitnoronha commented Apr 26, 2017

@ranjitnoronha
Copy link
Author

ranjitnoronha commented Apr 26, 2017

@johnmeneghini
Copy link
Contributor

johnmeneghini commented Apr 26, 2017

@johnmeneghini
Copy link
Contributor

johnmeneghini commented Apr 26, 2017

@ranjitnoronha
Copy link
Author

ranjitnoronha commented May 2, 2017

@johnmeneghini
Copy link
Contributor

johnmeneghini commented May 2, 2017

@benlwalker
Copy link
Member

benlwalker commented Jan 29, 2019

Closing this. DPDK is entirely abstracted behind the SPDK env library now.

@benlwalker benlwalker closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.