Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that the license identifier is deprecated #128

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Clarify that the license identifier is deprecated #128

merged 1 commit into from
Jan 5, 2022

Conversation

jgneff
Copy link
Contributor

@jgneff jgneff commented Jan 2, 2022

Clarify that the SPDX license identifier, and not the license itself,
is deprecated.

Signed-off-by: John Neffenger john@status6.com

Clarify that the SPDX license identifier, and not the license itself,
is deprecated.

Signed-off-by: John Neffenger <john@status6.com>
@jgneff
Copy link
Contributor Author

jgneff commented Jan 2, 2022

Closes #127.

@goneall
Copy link
Member

goneall commented Jan 3, 2022

@jlovejoy @swinslow @zvr FYI - This will change the text on the individual license pages. Let me know if you have any concerns about the change, otherwise I will merge these in.

@goneall
Copy link
Member

goneall commented Jan 3, 2022

@jgneff Thanks for the PR. Do you need this included in the next publication of the license list? If so, I can spin another release of the utility.

@jgneff
Copy link
Contributor Author

jgneff commented Jan 3, 2022

Do you need this included in the next publication of the license list?

@goneall Thanks, Gary. You can update the website whenever is convenient. I suspect most people don't click through from the Ubuntu and GNOME Software apps to the SPDX website, but it's just something that has been bothering me for quite some time.

By the way, I was going to be even more specific with the text "This SPDX license identifier has been deprecated since license list version ...", but "SPDX" is not used anywhere else on the page when talking about the identifier, so I just added the one word.

@swinslow
Copy link
Member

swinslow commented Jan 4, 2022

+1 to the change, definitely clearer with adding "identifier" here. Thank you @jgneff!

@jlovejoy
Copy link
Member

jlovejoy commented Jan 4, 2022

+1 - agreed, this is more accurate. Good catch!

@goneall
Copy link
Member

goneall commented Jan 5, 2022

The check failed due to a known issue #129

I'll go ahead and merge the PR.

@goneall goneall merged commit b8718c7 into spdx:master Jan 5, 2022
@jgneff jgneff deleted the clarify-deprecated branch January 5, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants