Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require the SPDX version to be 1.2 #53

Closed
yash-nisar opened this issue Mar 19, 2018 · 3 comments
Closed

Do not require the SPDX version to be 1.2 #53

yash-nisar opened this issue Mar 19, 2018 · 3 comments

Comments

@yash-nisar
Copy link
Contributor

yash-nisar commented Mar 19, 2018

@sschuberth @pombredanne
According to 2ecb365, we do not require the version to be 1.2, but we have a bug. (still require the version to be 1.2)

Steps to reproduce:

  1. Modify SPDXSimpleTag.tag and replace this line -> SPDXVersion: SPDX-1.2 with SPDXVersion: SPDX-1.1.
  2. Run python parse_tv.py '../data/SPDXSimpleTag.tag' from the examples directory.

Output that we receive:

examples git:(master) ✗ python parse_tv.py '../data/SPDXSimpleTag.tag'
Generating LALR tables
SPDXVersion must be SPDX-1.2 found SPDX-1.1.
Errors encountered while parsing

The cause of this behaviour is the given snippet inside tagvaluebuilders.py:

if vers == version.Version(major=1, minor=2):
    doc.version = vers
    return True
@sschuberth
Copy link
Member

Hi @yash-nisar. I'm sorry, but I'm going to pull myself out of this project as I personally have to need for it anymore, and I'm not a real Python guy anyway. As a result, I will probably not respond to issues or pull requests.

@yash-nisar
Copy link
Contributor Author

yash-nisar commented Mar 19, 2018 via email

@yash-nisar
Copy link
Contributor Author

@pombredanne Your views ?

yash-nisar added a commit to yash-nisar/tools-python that referenced this issue Apr 28, 2018
Signed-off-by: Yash Nisar <yash.nisar@somaiya.edu>
yash-nisar added a commit to yash-nisar/tools-python that referenced this issue May 7, 2018
Signed-off-by: Yash Nisar <yash.nisar@somaiya.edu>
pombredanne added a commit that referenced this issue May 8, 2018
Do not require the SPDX version to be 1.2 #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants