Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cruciform, ellipse, C, Z, IAssymetric, RectoEllpise, SecantPile… #763

Conversation

kpne
Copy link

@kpne kpne commented Oct 5, 2021

…, SheetPile, Stadium and Trapezoidal section profiles

Description

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Tests not required

Docs

  • No updates needed

@kpne
Copy link
Author

kpne commented Oct 5, 2021

@jenessaman I've added the missing AdSec profile types.

@teocomi
Copy link
Member

teocomi commented Oct 12, 2021

Hey @Reynold-Chan can you please review if you have bandwidth for this sprint?

@Reynold-Chan
Copy link
Contributor

Reynold-Chan commented Oct 12, 2021

Hi @kpne can you please check the following guidelines in regard to contribution to the structural kit. https://speckle.community/t/introducing-structural-classes-for-speckle/1824 . Give a short post or reason as to why you think this should be needed. Read through the whole post to see whether you think it's suitable to include this in the kit and whether it fits into the schema . Thanks !

@kpne
Copy link
Author

kpne commented Oct 12, 2021 via email

@Reynold-Chan
Copy link
Contributor

Reynold-Chan commented Oct 12, 2021

Hi Kristjan,

please post this in the community forum first! sorry, i know this seems annoying. The purpose of this is for everyone to see in the community ! so others can comment. You can give a link to the PR in the discourse.

@kpne
Copy link
Author

kpne commented Oct 25, 2021

@Reynold-Chan
Copy link
Contributor

Closing this PR because I think there's a pure adsec definition defined already for the Arup branch now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants