Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the SpeckleDynamoConverter #10

Closed
teocomi opened this issue May 22, 2018 · 4 comments
Closed

Implement the SpeckleDynamoConverter #10

teocomi opened this issue May 22, 2018 · 4 comments
Labels
Milestone

Comments

@teocomi
Copy link
Member

@teocomi teocomi commented May 22, 2018

https://github.com/speckleworks/SpeckleDynamo/blob/master/SpeckleDynamoConverter/SpeckleDynamoConverter.cs

Status

Primitives

  • Numbers
  • Boolean
  • String
  • Null
  • Point
  • Vector
  • Plane

Linear

  • Line
  • Polygon
  • Rectangle
  • Polyline (Dynamo PolyCurve with all its curves straigth)

Curves

  • Circle
  • Arc (still buggy due some differences with Rhino)
  • Ellipse
  • EllipseArc (only ToSpeckle() as NurbsCurve)
  • Curve
  • PolyCurve
  • NurbsCurve
  • Helix (only ToSpeckle() as NurbsCurve)

Other Geometries

  • Mesh
  • Solids
  • Brep (SpeckleBrep needs a more defined structure)
  • Box (can be converted as Cuboid?)
  • Extrusion (same as Brep)

Without Dynamo counterpart (?)

  • Interval
  • Annotation
  • ArchivableDictionary/ Dictionary
@teocomi teocomi added the help wanted label May 22, 2018
@teocomi teocomi changed the title Add other geometry types to converter Implement the SpeckleDynamoConverter May 29, 2018
@didimitrie didimitrie added this to the 1.0.0-beta milestone May 29, 2018
@didimitrie
Copy link
Member

@didimitrie didimitrie commented May 29, 2018

For reference, Archivable dictionaries and such got a little bump/update to their serialisation part to normal dictionaries in speckle rhino. Nothing major, just a heads up!

Also some serialisation routines changed recently (PR is still awaiting approval).

The stuff is here: https://github.com/speckleworks/SpeckleRhino/blob/Dim/dev-fix-wierd-curves/SpeckleRhinoConverter/src/SpeckleRhGhConverter.cs

Some recent changes in core that might come of handy: ~all SpeckleObjects now have a GenerateHash() method that you can call outside of the constructor, and that takes care of setting up the hashes (geometry & geometry+properties).

This can be nicely used if you set object fields outside the constructor.

@ksobon
Copy link

@ksobon ksobon commented May 29, 2018

@teocomi this might help: https://github.com/ksobon/MantisShrimp/blob/master/Grasshopper/mantisshrimp.py

I did most of the conversions from Rhino>Dynamo there, so it would give you a leg up on this stuff. Also @archinate did a similar thing here: https://bitbucket.org/caseinc/rhynamo/src

Actually his might even be better since it's already in C#.

@alvpickmans alvpickmans mentioned this issue May 31, 2018
8 of 8 tasks complete
@alvpickmans
Copy link
Collaborator

@alvpickmans alvpickmans commented Jun 19, 2018

I've updated @teocomi's main thread to reflect the current status of SpeckleDynamoConverter.

@alvpickmans
Copy link
Collaborator

@alvpickmans alvpickmans commented Jul 9, 2018

All but brep/surface based geometries are implemented now. Closing this issue.

@alvpickmans alvpickmans closed this Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.