Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Implement the SpeckleDynamoConverter #10

Closed
20 of 24 tasks
teocomi opened this issue May 22, 2018 · 4 comments
Closed
20 of 24 tasks

Implement the SpeckleDynamoConverter #10

teocomi opened this issue May 22, 2018 · 4 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@teocomi
Copy link
Member

teocomi commented May 22, 2018

https://github.com/speckleworks/SpeckleDynamo/blob/master/SpeckleDynamoConverter/SpeckleDynamoConverter.cs

Status

Primitives

  • Numbers
  • Boolean
  • String
  • Null
  • Point
  • Vector
  • Plane

Linear

  • Line
  • Polygon
  • Rectangle
  • Polyline (Dynamo PolyCurve with all its curves straigth)

Curves

  • Circle
  • Arc (still buggy due some differences with Rhino)
  • Ellipse
  • EllipseArc (only ToSpeckle() as NurbsCurve)
  • Curve
  • PolyCurve
  • NurbsCurve
  • Helix (only ToSpeckle() as NurbsCurve)

Other Geometries

  • Mesh
  • Solids
  • Brep (SpeckleBrep needs a more defined structure)
  • Box (can be converted as Cuboid?)
  • Extrusion (same as Brep)

Without Dynamo counterpart (?)

  • Interval
  • Annotation
  • ArchivableDictionary/ Dictionary
@teocomi teocomi added the help wanted Extra attention is needed label May 22, 2018
@teocomi teocomi changed the title Add other geometry types to converter Implement the SpeckleDynamoConverter May 29, 2018
@didimitrie didimitrie added this to the 1.0.0-beta milestone May 29, 2018
@didimitrie
Copy link
Member

For reference, Archivable dictionaries and such got a little bump/update to their serialisation part to normal dictionaries in speckle rhino. Nothing major, just a heads up!

Also some serialisation routines changed recently (PR is still awaiting approval).

The stuff is here: https://github.com/speckleworks/SpeckleRhino/blob/Dim/dev-fix-wierd-curves/SpeckleRhinoConverter/src/SpeckleRhGhConverter.cs

Some recent changes in core that might come of handy: ~all SpeckleObjects now have a GenerateHash() method that you can call outside of the constructor, and that takes care of setting up the hashes (geometry & geometry+properties).

This can be nicely used if you set object fields outside the constructor.

@ksobon
Copy link

ksobon commented May 29, 2018

@teocomi this might help: https://github.com/ksobon/MantisShrimp/blob/master/Grasshopper/mantisshrimp.py

I did most of the conversions from Rhino>Dynamo there, so it would give you a leg up on this stuff. Also @archinate did a similar thing here: https://bitbucket.org/caseinc/rhynamo/src

Actually his might even be better since it's already in C#.

@alvpickmans alvpickmans mentioned this issue May 31, 2018
8 tasks
@alvpickmans
Copy link
Collaborator

I've updated @teocomi's main thread to reflect the current status of SpeckleDynamoConverter.

@alvpickmans
Copy link
Collaborator

All but brep/surface based geometries are implemented now. Closing this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants