Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for Xcode 10.1 (and Fix Warnings) #194

Merged
merged 7 commits into from Dec 21, 2018

Conversation

@nsforge
Copy link
Contributor

commented Dec 20, 2018

This PR:

  • Upgrades the project for Xcode 10.1
  • Adds all of the suggested compiler warnings suggested when when upgrading the project
  • Fixes all outstanding compiler warnings
  • Updates the iOS deployment target from 5.1.1 to 8.0 (since Xcode 10 only supports iOS 8.0+)
@nsforge nsforge changed the title Xcode 10.1 Upgrade for Xcode 10.1 (and Fix Warnings) Dec 20, 2018
Copy link
Contributor

left a comment

These changes look good to me, but the CI scripts are quite broken so we're not getting any automated testing of changes. Do you have any interest in fixing the build scripts, @nsforge?

@nsforge

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2018

I'm having a quick look into the CI scripts now…

@nsforge nsforge referenced this pull request Dec 21, 2018
@nsforge

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

I've created a separate PR to fix CI:
#196

@nsforge

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

@tonyarnold once #196 has been merged into master, I can merge master back into this PR so that we can get CI going again.

# Conflicts:
#	.travis.yml
#	Expecta.xcodeproj/project.pbxproj
@nsforge

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

@tonyarnold The CI fixes have been merged in, so this is ready for review again.

@tonyarnold tonyarnold merged commit fc2dd8b into specta:master Dec 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tonyarnold

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

Thanks for the contribution, @nsforge! Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.