Command line argument parsing improvements #1048
Conversation
FrankRay78
changed the title
patriksvensson
changed the title
patriksvensson
changed the title
|
@FrankRay78 From a quick look, it looks ok to me! I will set aside some time this weekend to dig into it a bit more. Does this one cover other pull requests? If so, could you close the other ones to avoid confusion? Thanks! |
There was a problem hiding this comment.
A minor thing, but otherwise, it looks good to me 👍
@phil-scott-78, @nils-a Anything you would want to be addressed before merging?
src/Spectre.Console.Cli/Internal/Parsing/CommandTreeTokenizer.cs
Outdated
Show resolved
Hide resolved
Nothing that you haven't addressed already. 👍 |
|
@FrankRay78 There are currently conflicts with the main branch. Could you rebase your PR branch with an updated main branch? If you're uncertain how to do this, we've got a guide for it in our Contribution Guidelines. I can also help you out with this if you add me as a contributor to your Spectre.Console repository. |
… unterminated), whitespace, hyphens and special characters (eg. emojis)
FrankRay78
force-pushed
the
PR-193-587-959-Command-line-argument-parsing
branch
from
bf32bb5
to
bc341f7
Compare
|
I've rebased and fixed the merge conflicts @patriksvensson. |
|
@FrankRay78 Merged! Thank you for this. Stellar work! Really happy with your work! 👍 |
The following three PR's, when taken jointly, represent a significant enhancement to existing command line parsing behaviour: #1036, #1029, #1040
However, they all make changes to CommandTreeTokenizer and introduce their own unit tests specifically for the CommandTreeTokenizer, and as such, merge conflicts will arise once any one of the PR's has been merged.
This PR encompasses all three PR's, successfully merged and with all conflicts resolved. The respective git histories have also been squashed so the changes for each issue can be more clearly examined.
All issues addressed by this single combined PR are: #959, #842, #890, #193 (and its open duplicate, #825), #587
As it's quite a big change, I'm happy to help in any way required @patriksvensson for you to accept in full, in part, with or without amendment etc.