Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect leading in tables #225

Closed
pgundlach opened this issue Feb 26, 2019 · 1 comment
Closed

Incorrect leading in tables #225

pgundlach opened this issue Feb 26, 2019 · 1 comment
Assignees
@pgundlach
Labels
Bug
Milestone
Version 3.8

Comments

@pgundlach
Copy link
Member 

<Layout xmlns="urn:speedata.de:2009/publisher/en"
  xmlns:sd="urn:speedata:2009/publisher/functions/en"
  version="3.7.1">

  <DefineFontfamily name="small" fontsize="4.2" leading="5">
    <Regular fontface="sans"/>
  </DefineFontfamily>

 <Record element="data">
   <PlaceObject>
      <Table fontface="small">
        <Tr><Td><Paragraph><Value>foo</Value></Paragraph></Td></Tr>
        <Tr><Td><Paragraph><Value>foo</Value></Paragraph></Td></Tr>
        <Tr><Td><Paragraph><Value>foo</Value></Paragraph></Td></Tr>
      </Table>
    </PlaceObject>
  </Record>
</Layout>

This is related to #221
@pgundlach pgundlach added the Bug label Feb 26, 2019
@pgundlach pgundlach added this to the Version 3.8 milestone Feb 26, 2019
@pgundlach pgundlach self-assigned this Feb 26, 2019
pgundlach added a commit that referenced this issue Feb 27, 2019
@pgundlach
Don't add struts at the beginning of paragraphs
d296c15 
This fixes line spacing problems such as #221 and #225
@pgundlach
Copy link
Member Author

Fixed by d296c15

pgundlach added a commit that referenced this issue Mar 19, 2019
@pgundlach
Don't add struts at the beginning of paragraphs
35fe2e6 
This fixes line spacing problems such as #221 and #225
pgundlach added a commit that referenced this issue Jun 14, 2019
@pgundlach
Insert struts at the beginning of paragraphs
5af208f 
... but don't set the font family if we don't have to.

This fixes #235 and is reverts #221, #225 and is related to d296c15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgundlach pgundlach

Labels
Bug
Projects
None yet
Milestone
Version 3.8
Development

No branches or pull requests
1 participant
@pgundlach