Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image not found issues #241

Closed
iclukas opened this issue Nov 18, 2019 · 2 comments
Closed

Image not found issues #241

iclukas opened this issue Nov 18, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@iclukas
Copy link
Contributor

@iclukas iclukas commented Nov 18, 2019

I ran into two issues here:

  • Missing intermediate certs make images from https sources non-readable. The same is probably true for invalid certs.
  • If the current user (running sp) has no write permissions to the IMGCACHE dir, an „Image not found!“ error is issued.

In both cases the error messages are very misleading. Clearer messages would have saved me several hours of debugging.

In the first case, I’m not really sure why the cert error is not being displayed.

In the second case, it seems like saveFileFromUrl() doesn’t properly output the error because the path exists and leads to a dir. It’s just not writeable. Not sure if MkDirAll() returns an error, but it wouldn’t be handled anyway.

@pgundlach pgundlach self-assigned this Nov 18, 2019
@pgundlach pgundlach added the Bug label Nov 18, 2019
@pgundlach pgundlach added this to the Version 3.8 milestone Nov 18, 2019
@pgundlach
Copy link
Member

@pgundlach pgundlach commented Nov 19, 2019

Actually the cert error is displayed, but totally out of sync (and I think it is not in the log file, so it is rather useless). I'll fix this by returning an error value and check for it.

I am not sure how to properly fix the second issue though. I will honor the error value from mkdir and now return all error values, so hopefully all things that can go wrong are now in the log file.

@pgundlach
Copy link
Member

@pgundlach pgundlach commented Nov 19, 2019

Thank you very much for the report. A new version of the publisher is now available for download (3.7.17).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants