Add Plugin Tests to builds - #143
Merged
Merged
Conversation
isaac-io
suggested changes
Aug 30, 2022
isaac-io
force-pushed
the
plugin-tests
branch
from
September 13, 2022 13:24
bbaa88b to
18b8bcb
Compare
facebook-github-bot
pushed a commit
to facebook/rocksdb
that referenced
this pull request
Dec 31, 2022
Summary: This is based on speedb PR [143](speedb-io/speedb#143). This PR adds the ability to add a xxx_TESTS variable to the make or cmake files for a plugin. When set, those files will be added to the unit tests built and executed by the corresponding make system. Note that the rule for building plugin tests via make could be expanded to almost every other unit test in RocksDB. This expansion would allow for a much smaller/simpler Makefile and make it easier to add new test files to RocksDB. Pull Request resolved: #11052 Reviewed By: cbi42 Differential Revision: D42212269 Pulled By: ajkr fbshipit-source-id: d02668f7f4466900d63c90bb4f7962d23fcc7114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a xxx_TESTS variable that contains the tests to build for the plugin. Create rules in CMake and Make to build the corresponding tests.
Note that the same paradigm can be used to build most/all tests, but was left for a second PR (to not complicate the change)