db_bench: bug fix inserted in #200 (#263)

[Yuval-Ariel]

No description provided.

[udi-speedb]

num_ is int64_t
It may all be OK, but please ask @mrambacher to verify that your fix compiles on Mac.
Just to verify that the modulo between uint64_t and int64_t will not cause any compilation issues

[Yuval-Ariel]

sure, @mrambacher can you please check that it compiles on your platform. i'll also open a ticket to add the build platform you're using to the CI

[mrambacher]

I am still seeing this error:
tools/db_bench_tool.cc:8999:21: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
int argc1 = 1 + argv_vec.size();

[udi-speedb]

Hi, So is the issue with the "int argc1 = 1 + argv_vec.size();"? Because it was somehow understood that it's with the XXH64 Udi

…

On Sat, Nov 26, 2022 at 9:57 PM mrambacher ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tools/db_bench_tool.cc <#265 (comment)>: > @@ -6851,7 +6851,7 @@ class Benchmark { // deterministically turns range_num to unsigned int uint64_t range_num_to_rand(uint64_t range_num) { std::string str = std::to_string(range_num); - unsigned int xxh64 = XXH64(str.data(), str.length(), 0); + uint64_t xxh64 = XXH64(str.data(), str.length(), 0); // % num_ since the rand num will be used to make keys which are expected in // that range return xxh64 % num_; I am still seeing this error: tools/db_bench_tool.cc:8999:21: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32] int argc1 = 1 + argv_vec.size(); — Reply to this email directly, view it on GitHub <#265 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZKU2DGTLKYLFM4QVY3SIQTWKJTT5ANCNFSM6AAAAAASIUXJXU> . You are receiving this because your review was requested.Message ID: ***@***.***>

-- Udi Ron S/W Engineer www.speedb.io | www.speed.dev <http://www.speedb.dev/> Can you hear the buzz? <https://github.com/speedb-io/speedb> <https://forum.speedb.dev/> Please consider our environment and only print this email if you really have to. This email is confidential and solely intended for the addressee. If you receive this email in error please notify the sender by return.

[udi-speedb]

Hi, Could you please fix on your side, verify that it passes compilation and send the fix to Yuval to so we can forget about it and move on? Thanks, Udi

…

On Sun, Nov 27, 2022 at 8:28 AM Udi Ron ***@***.***> wrote: Hi, So is the issue with the "int argc1 = 1 + argv_vec.size();"? Because it was somehow understood that it's with the XXH64 Udi On Sat, Nov 26, 2022 at 9:57 PM mrambacher ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In tools/db_bench_tool.cc > <#265 (comment)>: > > > @@ -6851,7 +6851,7 @@ class Benchmark { > // deterministically turns range_num to unsigned int > uint64_t range_num_to_rand(uint64_t range_num) { > std::string str = std::to_string(range_num); > - unsigned int xxh64 = XXH64(str.data(), str.length(), 0); > + uint64_t xxh64 = XXH64(str.data(), str.length(), 0); > // % num_ since the rand num will be used to make keys which are expected in > // that range > return xxh64 % num_; > > I am still seeing this error: > tools/db_bench_tool.cc:8999:21: error: implicit conversion loses integer > precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32] > int argc1 = 1 + argv_vec.size(); > > — > Reply to this email directly, view it on GitHub > <#265 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AZKU2DGTLKYLFM4QVY3SIQTWKJTT5ANCNFSM6AAAAAASIUXJXU> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> > -- Udi Ron S/W Engineer www.speedb.io | www.speed.dev <http://www.speedb.dev/> Can you hear the buzz? <https://github.com/speedb-io/speedb> <https://forum.speedb.dev/> Please consider our environment and only print this email if you really have to. This email is confidential and solely intended for the addressee. If you receive this email in error please notify the sender by return.

-- Udi Ron S/W Engineer www.speedb.io | www.speed.dev <http://www.speedb.dev/> Can you hear the buzz? <https://github.com/speedb-io/speedb> <https://forum.speedb.dev/> Please consider our environment and only print this email if you really have to. This email is confidential and solely intended for the addressee. If you receive this email in error please notify the sender by return.

[Yuval-Ariel]

using the -Wconversion flag raises the above issues but many more (too many)..