generic switch memtable - #297
Merged
Merged
Conversation
Closed
ayulas
changed the title
Contributor
Author
|
@Yuval-Ariel this is the PR for the generic switch memtable. pls run QA for this . tnx |
Contributor
|
unit tests fail in options/customizable_test.cc - LoadCustomizableTest.LoadMemTableRepFactoryTest |
Yuval-Ariel
approved these changes
Dec 17, 2022
Contributor
|
can you add an issue number to the commit? |
Contributor
|
LoadCustomizableTest.LoadMemTableRepFactoryTest still fails |
ayulas
force-pushed
the
296-switch-memtable-generic
branch
from
December 18, 2022 13:26
e396959 to
3fe82e3
Compare
Contributor
Author
|
@Yuval-Ariel added a better way to handle the memtable factory destructor. pls retest |
Yuval-Ariel
approved these changes
Dec 18, 2022
Yuval-Ariel
force-pushed
the
296-switch-memtable-generic
branch
from
December 18, 2022 19:16
3fe82e3 to
2211bdb
Compare
…t allocated memory as part of the constructor this will reduce the penelty time of switch mutable memtable which by definition will effect write flow (#296)
Yuval-Ariel
force-pushed
the
296-switch-memtable-generic
branch
from
December 18, 2022 19:26
5e3f746 to
c64b7ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generic switch memtable allows the ability to pre create memtable that allocated memory as part of the constructor
this will reduce the penelty time of switch mutable memtable which by definition will effect write flow