Improve spdb memtable performance (#298) - #299
Merged
Merged
Conversation
Contributor
Author
|
@erez-speedb @Yuval-Ariel can you pls run tests |
Contributor
|
@ayulas plz fix failed Check buck targets test |
ayulas
force-pushed
the
298-improve-spdb-memtable-perf
branch
from
December 18, 2022 14:15
b062d89 to
e5a788b
Compare
Contributor
Author
|
fixed |
Yuval-Ariel
self-requested a review
December 18, 2022 14:21
Yuval-Ariel
approved these changes
Dec 18, 2022
mrambacher
changed the title
ayulas
force-pushed
the
298-improve-spdb-memtable-perf
branch
from
December 19, 2022 14:05
e5a788b to
4e31d2b
Compare
Contributor
Author
|
@erez-speedb , @Yuval-Ariel pls check. it is rebased on the 298 |
ayulas
force-pushed
the
298-improve-spdb-memtable-perf
branch
2 times, most recently
from
December 19, 2022 17:38
be14410 to
704ca30
Compare
Yuval-Ariel
approved these changes
Dec 19, 2022
ayulas
force-pushed
the
298-improve-spdb-memtable-perf
branch
2 times, most recently
from
December 20, 2022 09:09
a6a638b to
98a49f2
Compare
hilikspdb
reviewed
Jan 9, 2023
hilikspdb
left a comment
hilikspdb
left a comment
Contributor
There was a problem hiding this comment.
- There would be a memory problem in configuration with small DRAM and large number of CF (such as XMCyber / Flink) due to the static size of the buckets of Mutexes ...
- we need to emphasis the fact that the user should change the number of buckets if she needs to work on a restricted memory environment.
- Please add comments ....
Contributor
Author
|
fixing the build issue |
hilikspdb
approved these changes
Jan 11, 2023
ayulas
force-pushed
the
298-improve-spdb-memtable-perf
branch
2 times, most recently
from
January 17, 2023 09:53
01bb530 to
62efec5
Compare
ayulas
force-pushed
the
298-improve-spdb-memtable-perf
branch
3 times, most recently
from
January 31, 2023 14:17
2ff2ce1 to
ca71de9
Compare
Reduce lock access between switch writes vectors Avoid unnecessary lock between read and writes Decrease the writes vectors numbers
ayulas
force-pushed
the
298-improve-spdb-memtable-perf
branch
from
February 1, 2023 15:33
ca71de9 to
8c37223
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review already done by @hilikspdb for that version