Makefile: Use speedb libs in build_size target#399
Merged
Yuval-Ariel merged 1 commit intoFeb 28, 2023
Merged
Conversation
mrambacher
reviewed
Feb 13, 2023
AmnonHanuhov
force-pushed
the
275-makefile-build_size-target-in-the-makefile-is-not-adjusted-to-speedb-libs
branch
from
February 14, 2023 20:28
97e0566 to
2c802f9
Compare
mrambacher
previously approved these changes
Feb 14, 2023
mrambacher
left a comment
mrambacher
left a comment
Contributor
There was a problem hiding this comment.
This looks like it works most of the time. However, I think if you said DEBUG_LEVEL=2 make build_size, it might fail. Might want to check that just to be safe.
Otherwise, looks good!
Contributor
|
@AmnonHanuhov , do you want to address marks last comment before i merge this? |
Contributor
Author
Yes, I will look into it today. |
Contributor
Author
|
@mrambacher Didn't seem to fail for me with DEBUG_LEVEL=2 |
AmnonHanuhov
force-pushed
the
275-makefile-build_size-target-in-the-makefile-is-not-adjusted-to-speedb-libs
branch
from
February 16, 2023 17:53
2c802f9 to
ddd5445
Compare
AmnonHanuhov
force-pushed
the
275-makefile-build_size-target-in-the-makefile-is-not-adjusted-to-speedb-libs
branch
from
February 23, 2023 18:40
ddd5445 to
10eac76
Compare
Yuval-Ariel
pushed a commit
that referenced
this pull request
May 2, 2023
Yuval-Ariel
pushed a commit
that referenced
this pull request
May 4, 2023
Yuval-Ariel
deleted the
275-makefile-build_size-target-in-the-makefile-is-not-adjusted-to-speedb-libs
branch
May 11, 2023 08:26
udi-speedb
pushed a commit
that referenced
this pull request
Nov 13, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Nov 15, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #275