411: prevent flush entry followed delete operations - #418
Merged
Conversation
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
March 7, 2023 10:25
cf66057 to
8c590cd
Compare
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
March 7, 2023 11:19
8c590cd to
ddc898d
Compare
mrambacher
reviewed
Mar 7, 2023
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
March 20, 2023 11:50
ddc898d to
9cb3b00
Compare
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
March 29, 2023 03:53
9cb3b00 to
eaf3fba
Compare
ayulas
changed the title
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
2 times, most recently
from
March 29, 2023 08:02
1eb75cb to
670db8a
Compare
hilikspdb
previously approved these changes
Mar 29, 2023
mrambacher
reviewed
Mar 30, 2023
mrambacher
left a comment
mrambacher
left a comment
Contributor
There was a problem hiding this comment.
Do you have unit tests to cover these changes?
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
April 2, 2023 02:40
670db8a to
6b820e8
Compare
hilikspdb
previously approved these changes
Apr 2, 2023
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
April 2, 2023 08:26
6b820e8 to
9d67e4e
Compare
hilikspdb
previously approved these changes
Apr 2, 2023
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
April 2, 2023 14:35
9d67e4e to
a5610d1
Compare
hilikspdb
previously approved these changes
Apr 2, 2023
hilikspdb
left a comment
hilikspdb
left a comment
Contributor
There was a problem hiding this comment.
i think this option should be CF option but for now I approve ....
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
April 3, 2023 01:39
a5610d1 to
cfc5575
Compare
Yuval-Ariel
self-requested a review
April 3, 2023 10:10
Yuval-Ariel
previously approved these changes
Apr 3, 2023
Yuval-Ariel
reviewed
Apr 4, 2023
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
April 17, 2023 10:34
5e1185a to
2139b5f
Compare
Contributor
Author
|
@Yuval-Ariel can you pls review the db_stress db_crash changes and approve so it will go to testing? tnx |
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
April 17, 2023 10:39
2139b5f to
dde478d
Compare
Contributor
|
LGTM |
Yuval-Ariel
previously approved these changes
Apr 17, 2023
Yuval-Ariel
previously approved these changes
Apr 17, 2023
Contributor
Author
|
Black box test failed I’m in it |
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
May 22, 2023 11:28
2ca279e to
fd12a59
Compare
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
June 8, 2023 10:14
fd12a59 to
f74f5c4
Compare
hilikspdb
approved these changes
Jun 8, 2023
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
June 8, 2023 10:48
f74f5c4 to
cb6efff
Compare
hilikspdb
approved these changes
Jun 8, 2023
Contributor
|
need to update the history file |
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
June 11, 2023 17:27
cb6efff to
b02957c
Compare
currently during memtable flush , if key has a match key in the delete range table and this record has no snapshot related to it, we still write it with its value to SST file. This feature keeps only the delete record and reduce SST size for later compaction.
ayulas
force-pushed
the
411-prevent-flush-single-delete-entry
branch
from
June 11, 2023 17:48
b02957c to
29f68e9
Compare
Contributor
Author
|
history file updated and also @Yuval-Ariel remark to me |
Contributor
Author
|
ci https://github.com/speedb-io/speedb/actions/runs/5236684706 passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.