Adding beezcli by ofriedma · Pull Request #427 · speedb-io/speedb

ofriedma · 2023-03-15T15:30:04Z

This Pull request is adding a wrapper around ldb and allow using ldb in interactive manner (it is yet possible to use it non interactive just like ldb).
It adds some new functionalities to ldb such as multiget,
summary of keys and values from dump command, allow to not present values on dump and idump.
Fix the ttl parameter, to allow ttl to get value and run compaction on top of db with ttl.

Resolves: #407

ofriedma · 2023-03-15T19:38:47Z

It is possible to review it

ayulas · 2023-03-20T20:20:35Z

+            << std::endl
+            << get_value << std::endl
+            << std::endl;
+  std::cout << "The value returned by db MultiGet before expiration are: "


pls move it as you did in the Get to after the call MultiGet

ayulas · 2023-03-20T20:21:43Z

+
+  s = db->Get(ropts, key1, &get_value);
+  if (s.IsNotFound()) {
+    std::cout << "Key has been expired as expected" << std::endl;


add by Get to the output

ayulas · 2023-03-20T20:22:47Z

+  }
+  statuses = db->MultiGet(ropts, keys, &values);
+  for (const auto& i : statuses) {
+    if (s.IsNotFound()) {


s??? the for is i...

your test passed cause you used previous s value from the Get...

ayulas · 2023-03-20T20:25:03Z

+    }
+  }
+  ropts.skip_expired_data = false;
+  std::cout << "Keys actually stored but expired by MultiGet, without "


be consistent - the output after the call as mention above

ayulas · 2023-03-20T20:26:17Z

+  statuses = db->MultiGet(ropts, keys, &values);
+  for (size_t i = 0; i < statuses.size(); ++i) {
+    if (statuses[i].ok()) {
+      std::cout << keys[i].ToStringView() << ":" << values[i] << std::endl;


dont you want to verify it is the values you are expected too?

ayulas · 2023-03-20T21:22:44Z

+  ropts.skip_expired_data = true;
+  std::vector<std::string> values;
+  ASSERT_TRUE(db_ttl_->MultiGet(ropts, {"a"}, &values)[0].IsNotFound());
+  ASSERT_TRUE(values[0].empty());


why you need it... if the MultiGet return not found ofcourse no values...

ayulas · 2023-03-20T21:23:58Z

+  CloseTtl();
+}
+
+TEST_F(TtlTest, DoNotSkipUnExpiredTtlGetTest) {


do not skip??? you set skip.. . you get the value cause it wasnt expired

ayulas · 2023-03-20T21:25:15Z

+  CloseTtl();
+}
+
+TEST_F(TtlTest, DoNotSkipReadOnlyTtlMultiGetTest) {


again the name do not skip is not what you set... ropts.skip_expired_data = true;

ayulas · 2023-03-20T21:25:27Z

+  CloseTtl();
+}
+
+TEST_F(TtlTest, DoNotSkipReadOnlyTtlGetTest) {


ayulas · 2023-03-20T21:30:49Z

+    h = nullptr;
+  }
+}
+


you need to add test that do flush/compaction after ttl expired so you see that eventhough you set skip_expired_data=false after flush if you try get the keys were skipped in the flush and werent written to the sst so they wont exist

ofriedma · 2023-03-21T17:48:39Z

  } else {
    // We successfully opened DB in single column family mode.
-    assert(column_families_.empty());
+    // assert(column_families_.empty());


what to do with this assert

ofriedma · 2023-04-03T15:48:22Z

@ayulas i added unit test and more comments other than that the code is the same has reviewed

ofriedma · 2023-04-04T15:31:19Z

@ayulas added #include <stdio.h> to beezcli.cc because it had an issue when compiled with clang

beezcli is an interactive tool wrapping ldb This commit adds some enhancement to ldb Resolves: speedb-io#407

ofriedma · 2023-04-04T16:31:47Z

added //clang-format off and //clang-format on around #include <stdio.h> otherwise clang-format will try to put stdio after readline which will lead to compilation error in clang

beezcli is an interactive tool wrapping ldb This commit adds some enhancement to ldb Resolves: #407

ofriedma added enhancement New feature or request usability To review A feature request that has not been reviewed yet bug fix Fixes a known bug labels Mar 15, 2023

ofriedma assigned Guyme Mar 15, 2023

ofriedma force-pushed the wip-ofriedma-beezcli branch from a469d0d to 335aca0 Compare March 15, 2023 15:32

ofriedma force-pushed the wip-ofriedma-beezcli branch from 335aca0 to bf8e845 Compare March 16, 2023 13:50

ofriedma requested a review from ayulas March 20, 2023 14:09

ayulas reviewed Mar 20, 2023

View reviewed changes

ofriedma force-pushed the wip-ofriedma-beezcli branch 4 times, most recently from e5c6fe6 to 840e249 Compare March 21, 2023 15:50

ofriedma commented Mar 21, 2023

View reviewed changes

ayulas previously approved these changes Mar 21, 2023

View reviewed changes

ofriedma dismissed ayulas’s stale review via 89e697d March 28, 2023 17:02

ofriedma force-pushed the wip-ofriedma-beezcli branch 3 times, most recently from 8069dbd to 103f9de Compare April 3, 2023 15:47

ofriedma requested a review from ayulas April 3, 2023 15:47

ayulas previously approved these changes Apr 4, 2023

View reviewed changes

ofriedma dismissed ayulas’s stale review via 384f7f4 April 4, 2023 13:25

ofriedma force-pushed the wip-ofriedma-beezcli branch from 103f9de to 384f7f4 Compare April 4, 2023 13:25

ofriedma requested a review from ayulas April 4, 2023 13:43

ayulas previously approved these changes Apr 4, 2023

View reviewed changes

ofriedma dismissed ayulas’s stale review via 941dfe2 April 4, 2023 15:28

ofriedma force-pushed the wip-ofriedma-beezcli branch from 384f7f4 to 941dfe2 Compare April 4, 2023 15:28

ofriedma requested a review from ayulas April 4, 2023 15:30

ayulas previously approved these changes Apr 4, 2023

View reviewed changes

adding beezcli and ttl support speedb-io#407

c37ed78

beezcli is an interactive tool wrapping ldb This commit adds some enhancement to ldb Resolves: speedb-io#407

ofriedma dismissed ayulas’s stale review via c37ed78 April 4, 2023 15:57

ofriedma force-pushed the wip-ofriedma-beezcli branch from 941dfe2 to c37ed78 Compare April 4, 2023 15:57

ofriedma requested a review from ayulas April 4, 2023 16:27

ofriedma requested a review from Guyme April 4, 2023 16:33

Guyme approved these changes Apr 4, 2023

View reviewed changes

Yuval-Ariel merged commit 4091672 into speedb-io:main Apr 5, 2023

Yuval-Ariel pushed a commit that referenced this pull request May 2, 2023

adding beezcli and ttl support (#427)

d487146

beezcli is an interactive tool wrapping ldb This commit adds some enhancement to ldb Resolves: #407

Yuval-Ariel pushed a commit that referenced this pull request May 4, 2023

adding beezcli and ttl support (#427)

57e540c

beezcli is an interactive tool wrapping ldb This commit adds some enhancement to ldb Resolves: #407

udi-speedb pushed a commit that referenced this pull request Nov 13, 2023

adding beezcli and ttl support (#427)

c9e4c41

beezcli is an interactive tool wrapping ldb This commit adds some enhancement to ldb Resolves: #407

udi-speedb pushed a commit that referenced this pull request Nov 15, 2023

adding beezcli and ttl support (#427)

c7bab4f

beezcli is an interactive tool wrapping ldb This commit adds some enhancement to ldb Resolves: #407

udi-speedb pushed a commit that referenced this pull request Dec 4, 2023

adding beezcli and ttl support (#427)

ed446ef

beezcli is an interactive tool wrapping ldb This commit adds some enhancement to ldb Resolves: #407

ofriedma added a commit that referenced this pull request Dec 5, 2023

adding beezcli and ttl support (#427)

cb12a68

beezcli is an interactive tool wrapping ldb This commit adds some enhancement to ldb Resolves: #407

Uh oh!

Conversation

ofriedma commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ofriedma commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ofriedma commented Apr 3, 2023

Uh oh!

ofriedma commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ofriedma commented Apr 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ofriedma commented Mar 15, 2023 •

edited

Loading

ofriedma commented Mar 15, 2023 •

edited

Loading

ofriedma commented Apr 4, 2023 •

edited

Loading