AVX512: fix disabling other optimizations - #489
Merged
Conversation
Contributor
Author
|
lets wait with the review for after the rebase |
udi-speedb
previously approved these changes
May 8, 2023
Contributor
|
Can you explain why this code is different than the vanilla RocksDB? |
Contributor
Author
|
since we dont want to run AVX512 together with ASAN. it crashes - #398 |
the previous commit disabled all the rest of the XXH optimizations since it didnt prevent the XXH_VECTOR from being defined as XXH_AVX512.
Yuval-Ariel
force-pushed
the
AVX512-disable-only-it
branch
from
May 11, 2023 06:06
7bdf142 to
67db50e
Compare
Contributor
Author
|
@udi-speedb plz reapprove, i've rebased on current main. |
udi-speedb
self-requested a review
May 11, 2023 08:11
udi-speedb
approved these changes
May 11, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Nov 19, 2023
fix - AXV512: don't use XXH3_accumulate_512 with ASAN (#398) the previous commit disabled all the rest of the XXH optimizations since it didnt prevent the XXH_VECTOR from being defined as XXH_AVX512.
udi-speedb
pushed a commit
that referenced
this pull request
Dec 5, 2023
fix - AXV512: don't use XXH3_accumulate_512 with ASAN (#398) the previous commit disabled all the rest of the XXH optimizations since it didnt prevent the XXH_VECTOR from being defined as XXH_AVX512.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the previous commit disabled all the rest of the XXH optimizations since it didnt prevent the XXH_VECTOR from being defined as XXH_AVX512.
this PR fixes that.