Skip to content

Always assume optimize_filters_for_memory=false when creating a paired bloom filter - #528

Merged
ofriedma merged 1 commit into
mainfrom
488-db_stress-assertion-in-filter_policycc-when-using-paired-bloom-filter
Jun 7, 2023
Merged

ofriedma merged 1 commit into
mainfrom
488-db_stress-assertion-in-filter_policycc-when-using-paired-bloom-filter

Conversation

@udi-speedb

Copy link
Copy Markdown
Contributor

No description provided.

@udi-speedb
udi-speedb requested a review from ofriedma May 24, 2023 18:51
@Yuval-Ariel

Copy link
Copy Markdown
Contributor

this seems relevant - #492

@udi-speedb

Copy link
Copy Markdown
Contributor Author

this seems relevant - #492

Not likely but I will check if the failed unit test in #492 is affected (assuming that is what you have meant)

@udi-speedb
udi-speedb force-pushed the 488-db_stress-assertion-in-filter_policycc-when-using-paired-bloom-filter branch from 0de63a3 to 18bab49 Compare June 7, 2023 09:01
@udi-speedb
udi-speedb requested review from ofriedma and removed request for ofriedma June 7, 2023 09:07
@udi-speedb

Copy link
Copy Markdown
Contributor Author

@ofriedma - I have added to HISTORY.md and opened an issue (#541) to properly handle the sanitization.
Please review and approve

@ofriedma
ofriedma merged commit fc24b77 into main Jun 7, 2023
@Yuval-Ariel
Yuval-Ariel deleted the 488-db_stress-assertion-in-filter_policycc-when-using-paired-bloom-filter branch June 7, 2023 12:22
udi-speedb added a commit that referenced this pull request Nov 19, 2023
udi-speedb added a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db_stress: Assertion in filter_policy.cc when using Paired Bloom Filter

3 participants