Skip to content

Print optimize_filters_for_memory option to the log (#536) - #537

Merged
Yuval-Ariel merged 1 commit into
mainfrom
536-optimize_filters_for_memory-option-is-not-printed-to-the-log
Jun 11, 2023
Merged

Yuval-Ariel merged 1 commit into
mainfrom
536-optimize_filters_for_memory-option-is-not-printed-to-the-log

Conversation

@udi-speedb

Copy link
Copy Markdown
Contributor

No description provided.

@udi-speedb
udi-speedb requested a review from ofriedma June 6, 2023 03:15
@udi-speedb udi-speedb linked an issue Jun 6, 2023 that may be closed by this pull request
@udi-speedb

udi-speedb commented Jun 6, 2023 •

Copy link
Copy Markdown
Contributor Author

@ofriedma - I am not sure there is a better way to sanitize the offm (optimize_filters_for_memory) option.
I have asked @mrambacher for advice in the slack channel, however, I think that we may leave it as is (+ add to the history file + gitbook documentation).
Anyway, I'll wait for @mrambacher's advice and see.
In the meantime, I have opened a separate issue to print the value of offm to the log which is currently missing.

@ofriedma ofriedma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofriedma ofriedma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yuval-Ariel
Yuval-Ariel merged commit 3d4c9d1 into main Jun 11, 2023
@Yuval-Ariel
Yuval-Ariel deleted the 536-optimize_filters_for_memory-option-is-not-printed-to-the-log branch June 11, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

optimize_filters_for_memory option is NOT printed to the log

3 participants