Skip to content

560: Tombstone test fixes as a result of not clear local variable#561

Merged
Yuval-Ariel merged 1 commit into
mainfrom
560-tombsobne-test-failure
Jun 14, 2023
Merged

560: Tombstone test fixes as a result of not clear local variable#561
Yuval-Ariel merged 1 commit into
mainfrom
560-tombsobne-test-failure

Conversation

@ayulas

@ayulas ayulas commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@ayulas ayulas requested a review from Yuval-Ariel June 13, 2023 16:21
@ayulas

ayulas commented Jun 13, 2023

Copy link
Copy Markdown
Contributor Author

@yuval pls review . for some reason the unit test passed on the CI but not on the mac. now it is passed on the mac as well
it must inserted to the version... no need performance test to it

@ayulas ayulas force-pushed the 560-tombsobne-test-failure branch from 4442950 to 7638c2d Compare June 13, 2023 16:25

@Yuval-Ariel Yuval-Ariel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayulas

ayulas commented Jun 13, 2023

Copy link
Copy Markdown
Contributor Author

toda!!!

@Yuval-Ariel Yuval-Ariel linked an issue Jun 13, 2023 that may be closed by this pull request
@Yuval-Ariel Yuval-Ariel merged commit 201de3d into main Jun 14, 2023
@Yuval-Ariel Yuval-Ariel deleted the 560-tombsobne-test-failure branch June 14, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

merge issue with Tombstone.. cause failed test on Mac

2 participants