Skip to content

548: Support Spdb memtable in Java and C - #612

Merged
Yuval-Ariel merged 1 commit into
mainfrom
548-java-spdb-memtable-support
Aug 19, 2023
Merged

548: Support Spdb memtable in Java and C#612
Yuval-Ariel merged 1 commit into
mainfrom
548-java-spdb-memtable-support

Conversation

@ayulas

@ayulas ayulas commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@Guyme Guyme linked an issue Jul 24, 2023 that may be closed by this pull request
@Guyme
Guyme requested a review from RoyBenMoshe July 24, 2023 12:18

@mrambacher mrambacher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the preferred way of adding code in the plugin directory into Java. This now makes Java dependent on compiling with the Speedb features enabled and requires the code to be managed/merged between RocksDB and Speedb versions.

If the goal is to minimize Speedb changes in the base RocksDB code, then this code should be separated out into its own files/directory under the speedb plugin and added to Java accordingly.

@ayulas
ayulas force-pushed the 548-java-spdb-memtable-support branch 5 times, most recently from ba75ac9 to 09d6240 Compare August 14, 2023 12:40
Comment thread HISTORY.md Outdated
@Yuval-Ariel

Copy link
Copy Markdown
Contributor

it seems that this PR also make the speedb memtable not a plugin, right?
if so then either update the description or better yet, divide into 2 separate PRs

@Guyme Guyme changed the title 548: Support Spdb memtable in Java 548: Support Spdb memtable in Java and C Aug 16, 2023
@ayulas
ayulas force-pushed the 548-java-spdb-memtable-support branch from 09d6240 to b6b3f8a Compare August 16, 2023 15:00
@ayulas

ayulas commented Aug 16, 2023

Copy link
Copy Markdown
Contributor Author

this ticket must be insert after 639-move-spdb-memtable-from-plugin-to-main-code

@mrambacher

Copy link
Copy Markdown
Contributor

For Java, this could have been done via the CreateFromString in the same manner that Filters were exposed. This would have eliminated the need for all of the custom classes and changing the code to a plugin. Is there a reason this approach was not chosen?

Something similar could have been implemented in C, but I am not aware of any exposures of CreateFromString in that language as of yet.

@ayulas
ayulas force-pushed the 548-java-spdb-memtable-support branch from b6b3f8a to be6d914 Compare August 18, 2023 15:38
@Yuval-Ariel
Yuval-Ariel merged commit 54bd545 into main Aug 19, 2023
@Yuval-Ariel
Yuval-Ariel deleted the 548-java-spdb-memtable-support branch August 19, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is Sorted Hash Memtable supported via Java API?

4 participants