Add the offset and size to the dump SST footer details

[git-hulk]

Before applying this PR, the footer details:

Footer Details:
--------------------------------------
  metaindex handle: B0E499405C
  index handle: 8AC49940CD17
  table_magic_number: 9863518390377041911
  format version: 5

and after

Footer Details:
--------------------------------------
  metaindex handle: B0E499405C offset: 134640176 size: 92
  index handle: 8AC49940CD17 offset: 134636042 size: 3021
  table_magic_number: 9863518390377041911
  format version: 5

This closes #404

[udi-speedb]

@git-hulk Looks good.
Please just update HISTORY.md as well.
Thanks

[git-hulk]

@udi-speedb Thanks for your review. I have updated the HISTORY.md, please take a look.

[udi-speedb]

@git-hulk Thanks for that.

Just one last minor thing . Please add the issue's number to the end of the description you have added to the HISTORY.md like so:
* sst_dump: display metaindex_handle and the index_handle's offset and size in footer information (#404).

[git-hulk]

@git-hulk Thanks for that.

Just one last minor thing . Please add the issue's number to the end of the description you have added to the HISTORY.md like so: * sst_dump: display metaindex_handle and the index_handle's offset and size in footer information (#404).

Sure, sorry for missing that.

[udi-speedb]

@git-hulk Thanks for that.
Just one last minor thing . Please add the issue's number to the end of the description you have added to the HISTORY.md like so: * sst_dump: display metaindex_handle and the index_handle's offset and size in footer information (#404).

Sure, sorry for missing that.

No problem. Thanks a lot.

[udi-speedb]

@git-hulk
Please squash your commits into a single one and force push.
The commit message of the first commit is fine as the commit message for the single, squashed commit. Just please also add the issue number at the end of that commit message:
Add the offset and size into the dump SST footer detail (#404)

Once done, I will approve the PR.

[git-hulk]

@udi-speedb Done, thank you! I will take care of those rules next time.

[udi-speedb]

@udi-speedb Done, thank you! I will take care of those rules next time.

@git-hulk Thanks a lot for your contribution.

[udi-speedb]

@git-hulk I apologize, but I forgot to ask you to run make format on your code. So, please do and force push again.

[git-hulk]

@git-hulk I apologize, but I forgot to ask you to run make format on your code. So, please do and force push again.

My bad, I should go through the CONTRIBUTING.md doc first before writing the code. Thanks for your guidance.

[udi-speedb]

@git-hulk I apologize, but I forgot to ask you to run make format on your code. So, please do and force push again.

My bad, I should go through the CONTRIBUTING.md doc first before writing the code. Thanks for your guidance.

No problem. Thanks again for your cooperation and contribution.

[git-hulk]

@udi-speedb Looks like the check history and license are not correct, should I fix it?

https://github.com/speedb-io/speedb/blob/main/.github/workflows/check_license_and_history.yml#L36

I guess it should checkout the repository before checking.

[udi-speedb]

@udi-speedb Looks like the check history and license are not correct, should I fix it?

https://github.com/speedb-io/speedb/blob/main/.github/workflows/check_license_and_history.yml#L36

I guess it should checkout the repository before checking.

No need. It's a known issue. We need to resolve it on our side. Thanks

[git-hulk]

@udi-speedb Should I worry about the failure of the test? It looks like didn't relate to PR's change.

[udi-speedb]

@udi-speedb Should I worry about the failure of the test? It looks like didn't relate to PR's change.

Indeed seems totally unrelated to your change. I am handling this. Will let you know if anything else is needed. Thanks

[udi-speedb]

@git-hulk I aplogize, but I need to ask you to update the license text at the top of the file you have modified. We need to update our CONTRIBUTING.md file to reflect this recent decision. You may find the text to add in this issue:
#713 .
As an example, you may see column_family.cc

Please do not force push your updates. Just add commits. At the time of merging, we will squash and leave only the applicable commit message.
Thanks for your cooperation.

[git-hulk]

Hi @udi-speedb It's my pleasure, thanks for you review. I think it's a good chance to learn the speedb develop flow.