Skip to content

Enable-Speedb-Feature: Use Scoped Pinning Policy instead of Default Policy - #715

Merged
udi-speedb merged 5 commits into
mainfrom
628-add-tablepinningpolicy-to-enablespeedbfeaturescf-function
Oct 17, 2023
Merged

Enable-Speedb-Feature: Use Scoped Pinning Policy instead of Default Policy#715
udi-speedb merged 5 commits into
mainfrom
628-add-tablepinningpolicy-to-enablespeedbfeaturescf-function

Conversation

@udi-speedb

Copy link
Copy Markdown
Contributor

No description provided.

@udi-speedb
udi-speedb force-pushed the 628-add-tablepinningpolicy-to-enablespeedbfeaturescf-function branch from 687b2f1 to 440b40c Compare October 13, 2023 08:12
@udi-speedb

Copy link
Copy Markdown
Contributor Author

@erez-speedb - Please run performance tests on the branch. Thanks

@hilikspdb

Copy link
Copy Markdown
Contributor

@udi-speedb the pinning policy must be shared object between all the CF (and not recreated per CF) .. sorry that i have missed it

@hilikspdb hilikspdb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pinning must be a shared object (like the cache) sorry that I have missed it...

@udi-speedb

Copy link
Copy Markdown
Contributor Author

@udi-speedb the pinning policy must be shared object between all the CF (and not recreated per CF) .. sorry that i have missed it

@hilikspdb - Indeed you are correct. I have also missed that.

@udi-speedb
udi-speedb requested a review from hilikspdb October 16, 2023 05:56

@hilikspdb hilikspdb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Yuval-Ariel
Yuval-Ariel self-requested a review October 17, 2023 12:09
@udi-speedb udi-speedb closed this Oct 17, 2023
@udi-speedb udi-speedb reopened this Oct 17, 2023
@udi-speedb
udi-speedb merged commit 5bf9c60 into main Oct 17, 2023
@Yuval-Ariel
Yuval-Ariel deleted the 628-add-tablepinningpolicy-to-enablespeedbfeaturescf-function branch October 17, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TablePinningPolicy to EnableSpeedbFeaturesCF function

5 participants