Skip to content

memory reporting - #757

Merged
ofriedma merged 10 commits into
mainfrom
wip-ofriedma-mem-reporting
Jan 22, 2024
Merged

memory reporting#757
ofriedma merged 10 commits into
mainfrom
wip-ofriedma-mem-reporting

Conversation

@ofriedma

@ofriedma ofriedma commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Add arena stats, count BlockFetcher allocations, print db memory stats to logs
fixes: #481

@ofriedma ofriedma added the enhancement New feature or request label Nov 8, 2023
@ofriedma
ofriedma requested a review from speedbmike November 8, 2023 09:26
@ofriedma ofriedma self-assigned this Nov 8, 2023
@ofriedma

Copy link
Copy Markdown
Contributor Author

@speedbmike , Changed from unordered_map to vector + enum

@ofriedma
ofriedma force-pushed the wip-ofriedma-mem-reporting branch from d884dae to 53bffd8 Compare November 26, 2023 14:15
speedbmike
speedbmike previously approved these changes Nov 26, 2023
Comment thread db/malloc_stats.cc Outdated
Comment thread memory/allocator.h Outdated
@ofriedma

Copy link
Copy Markdown
Contributor Author

@speedbmike please re-review

speedbmike
speedbmike previously approved these changes Nov 28, 2023
@ofriedma
ofriedma dismissed speedbmike’s stale review December 25, 2023 09:44

The merge-base changed after approval.

Add arena stats, count BlockFetcher allocations, print db memory stats
to logs
@ofriedma
ofriedma force-pushed the wip-ofriedma-mem-reporting branch from 9fc15ea to 7d9c156 Compare December 25, 2023 16:17
@ofriedma
ofriedma requested a review from speedbmike December 25, 2023 16:17
@ofriedma

ofriedma commented Dec 25, 2023

Copy link
Copy Markdown
Contributor Author

@speedbmike please review, there were no conflicts for the rebase

@ofriedma

Copy link
Copy Markdown
Contributor Author

@speedbmike please approve

Guyme
Guyme previously approved these changes Dec 28, 2023
speedbmike
speedbmike previously approved these changes Dec 28, 2023
@ofriedma
ofriedma dismissed stale reviews from speedbmike and Guyme via 0a04e4b December 31, 2023 08:52
@ofriedma
ofriedma requested a review from speedbmike January 2, 2024 12:45
speedbmike
speedbmike previously approved these changes Jan 4, 2024
@ofriedma

ofriedma commented Jan 4, 2024

Copy link
Copy Markdown
Contributor Author

@Yuval-Ariel @Guyme @maxb-io it is failing on Check license for CMakeLists.txt and build_detect_platform is it necessary for these files?

@ofriedma

ofriedma commented Jan 7, 2024

Copy link
Copy Markdown
Contributor Author

@Guyme @Yuval-Ariel ?

@Yuval-Ariel

Copy link
Copy Markdown
Contributor

no idea

udi-speedb
udi-speedb previously approved these changes Jan 7, 2024
udi-speedb
udi-speedb previously approved these changes Jan 7, 2024
@ofriedma
ofriedma merged commit 0d7234d into main Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory Tracking

5 participants