From d1208ebd8951c08b9fa0c4f4e328bb49774705d6 Mon Sep 17 00:00:00 2001 From: Tiago Alves Date: Tue, 14 May 2019 17:38:48 +0100 Subject: [PATCH 1/9] Added ideas from speigg and simplec-dev. --- README.md | 23 ++++++++++++------ lib/after-prepare.js | 55 +++++++++++++++++++++++++------------------- 2 files changed, 47 insertions(+), 31 deletions(-) diff --git a/README.md b/README.md index 22e3f34..9ebe5fb 100644 --- a/README.md +++ b/README.md @@ -1,17 +1,18 @@ -Nativescript hook plugin to maintain native app version -======================================================= +# Nativescript hook plugin to maintain native app version and bump version code / bundle version -This plugin just takes the `nativescript.version` property from `package.json` and puts on the specific platform resources: `AndroidManifest.xml` file for the Android sources, and `Info.plist` for iOS sources. +This plugin takes the `version` property from `package.json` (either `./package.json` or `./app/package.json`) and puts on the specific platform resources: `AndroidManifest.xml` file for the Android sources, and `Info.plist` for iOS sources. + +This plugin is mainly a fork of [jacargentina/nativescript-dev-version](https://github.com/jacargentina/nativescript-dev-version), with the great ideas from [speigg/nativescript-dev-version](https://github.com/speigg/nativescript-dev-version/tree/patch-1) and [simplec-dev/nativescript-dev-version](https://github.com/simplec-dev/nativescript-dev-version). + +## How to use -How to use ----------- ``` $ tns plugin add nativescript-dev-version ``` The above command installs this module and installs the necessary NativeScript hooks. -Then, specify and maintain the desired release version on the `package.json` file under the `nativescript.version` property, for example: +Then, specify and maintain the desired release version on the `./package.json` file under the `nativescript.version` property, for example: ```json { @@ -24,5 +25,13 @@ Then, specify and maintain the desired release version on the `package.json` fil } ``` -When running `tns prepare ...` the hooks will take care of the native resources, and your app will get the `1.2.3` version number! +or in `./app/package.json`: + +```json +{ + ... + "version": "1.2.3" +} +``` +When running `tns prepare ...` the hooks will take care of the native resources, and your app will get the `1.2.3` version number! diff --git a/lib/after-prepare.js b/lib/after-prepare.js index 75a2f01..22cb74f 100644 --- a/lib/after-prepare.js +++ b/lib/after-prepare.js @@ -5,27 +5,34 @@ var Promise = require('bluebird'); var AndroidManifest = require('androidmanifest'); var iOSPList = require('plist'); -module.exports = function ($logger, $projectData, $usbLiveSyncService) { - var appPackage = require($projectData.projectFilePath); - if (!appPackage.nativescript || !appPackage.nativescript.version) { - $logger.warn('Nativescript version is not defined. Skipping set native package version.'); - return; - } - var platformService = $injector.resolve('platformService'); - var platformsData = $injector.resolve('platformsData'); - return Promise.each(platformService.getPreparedPlatforms($projectData), function (platform) { - var platformData = platformsData.getPlatformData(platform); - if (platform == 'android') { - var manifest = new AndroidManifest().readFile(platformData.configurationFilePath) - manifest.$('manifest').attr('android:versionCode', appPackage.nativescript.version.replace(/\./g, '')) - manifest.$('manifest').attr('android:versionName', appPackage.nativescript.version); - manifest.writeFile(platformData.configurationFilePath); - } - else if (platform == 'ios') { - var plist = iOSPList.parse(fs.readFileSync(platformData.configurationFilePath, 'utf8')); - plist.CFBundleShortVersionString = appPackage.nativescript.version; - plist.CFBundleVersion = appPackage.nativescript.version; - fs.writeFileSync(platformData.configurationFilePath, iOSPList.build(plist)); - } - }); -} \ No newline at end of file +module.exports = function($logger, $projectData, $usbLiveSyncService) { + var appPackage = require($projectData.projectFilePath); + var appVersion = (appPackage.nativescript && appPackage.nativescript.version) || appPackage.version; + if (!appVersion) { + $logger.warn('Nativescript version is not defined. Skipping set native package version.'); + return; + } + var platformService = $injector.resolve('platformService'); + var platformsData = $injector.resolve('platformsData'); + return Promise.each(platformService.getPreparedPlatforms($projectData), function(platform) { + var platformData = platformsData.getPlatformData(platform); + if (platform == 'android') { + var manifest = new AndroidManifest().readFile(platformData.configurationFilePath); + + // transforms e.g. "1.2.3" into 1002003. + var versionCode = appPackage.nativescript.version.split('.').reduce((acc, v, i, a) => { + return acc + v * Math.pow(10, (a.length - i - 1) * 3); + }, 0); + + manifest.$('manifest').attr('android:versionCode', versionCode); + + manifest.$('manifest').attr('android:versionName', appVersion); + manifest.writeFile(platformData.configurationFilePath); + } else if (platform == 'ios') { + var plist = iOSPList.parse(fs.readFileSync(platformData.configurationFilePath, 'utf8')); + plist.CFBundleShortVersionString = appVersion; + plist.CFBundleVersion = appVersion; + fs.writeFileSync(platformData.configurationFilePath, iOSPList.build(plist)); + } + }); +}; From c70e2790bf0397a67dbd87e9ccc27235ba14af8c Mon Sep 17 00:00:00 2001 From: Tiago Alves Date: Tue, 14 May 2019 17:41:24 +0100 Subject: [PATCH 2/9] Fixed README. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9ebe5fb..59c4877 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -# Nativescript hook plugin to maintain native app version and bump version code / bundle version +# Nativescript hook plugin to maintain native app version This plugin takes the `version` property from `package.json` (either `./package.json` or `./app/package.json`) and puts on the specific platform resources: `AndroidManifest.xml` file for the Android sources, and `Info.plist` for iOS sources. From 5cf9b1f85f11e89f2b873f04d0e9a8f9980fc751 Mon Sep 17 00:00:00 2001 From: Tiago Alves Date: Tue, 14 May 2019 18:17:41 +0100 Subject: [PATCH 3/9] Fix reading app version. --- README.md | 6 +++--- lib/after-prepare.js | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 59c4877..ca7f044 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Nativescript hook plugin to maintain native app version -This plugin takes the `version` property from `package.json` (either `./package.json` or `./app/package.json`) and puts on the specific platform resources: `AndroidManifest.xml` file for the Android sources, and `Info.plist` for iOS sources. +This plugin takes the `version` property from `package.json` and puts on the specific platform resources: `AndroidManifest.xml` file for the Android sources, and `Info.plist` for iOS sources. This plugin is mainly a fork of [jacargentina/nativescript-dev-version](https://github.com/jacargentina/nativescript-dev-version), with the great ideas from [speigg/nativescript-dev-version](https://github.com/speigg/nativescript-dev-version/tree/patch-1) and [simplec-dev/nativescript-dev-version](https://github.com/simplec-dev/nativescript-dev-version). @@ -25,12 +25,12 @@ Then, specify and maintain the desired release version on the `./package.json` f } ``` -or in `./app/package.json`: +or: ```json { - ... "version": "1.2.3" + ... } ``` diff --git a/lib/after-prepare.js b/lib/after-prepare.js index 22cb74f..ca504d5 100644 --- a/lib/after-prepare.js +++ b/lib/after-prepare.js @@ -20,12 +20,11 @@ module.exports = function($logger, $projectData, $usbLiveSyncService) { var manifest = new AndroidManifest().readFile(platformData.configurationFilePath); // transforms e.g. "1.2.3" into 1002003. - var versionCode = appPackage.nativescript.version.split('.').reduce((acc, v, i, a) => { + var versionCode = appVersion.split('.').reduce((acc, v, i, a) => { return acc + v * Math.pow(10, (a.length - i - 1) * 3); }, 0); manifest.$('manifest').attr('android:versionCode', versionCode); - manifest.$('manifest').attr('android:versionName', appVersion); manifest.writeFile(platformData.configurationFilePath); } else if (platform == 'ios') { From 855406924bf61e7627e8f989fa1dfd274fd077b0 Mon Sep 17 00:00:00 2001 From: Tiago Alves Date: Wed, 26 Jun 2019 11:33:05 +0000 Subject: [PATCH 4/9] Use versionNumber too. --- README.md | 26 +++++++++++--- lib/after-prepare.js | 86 +++++++++++++++++++++++++++----------------- 2 files changed, 75 insertions(+), 37 deletions(-) diff --git a/README.md b/README.md index ca7f044..d64d86b 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Nativescript hook plugin to maintain native app version -This plugin takes the `version` property from `package.json` and puts on the specific platform resources: `AndroidManifest.xml` file for the Android sources, and `Info.plist` for iOS sources. +This plugin takes the `version` and `versionNumber` properties from `package.json` and puts on the specific platform resources: `AndroidManifest.xml` file for the Android sources, and `Info.plist` for iOS sources. This plugin is mainly a fork of [jacargentina/nativescript-dev-version](https://github.com/jacargentina/nativescript-dev-version), with the great ideas from [speigg/nativescript-dev-version](https://github.com/speigg/nativescript-dev-version/tree/patch-1) and [simplec-dev/nativescript-dev-version](https://github.com/simplec-dev/nativescript-dev-version). @@ -18,7 +18,8 @@ Then, specify and maintain the desired release version on the `./package.json` f { "nativescript": { "id": "org.nativescript.MySampleApp", - "version": "1.2.3" + "version": "1.2.3", + "versionNumber": "1" ... }, ... @@ -29,9 +30,26 @@ or: ```json { - "version": "1.2.3" + "version": "1.2.3", + "versionNumber": "1" ... } ``` -When running `tns prepare ...` the hooks will take care of the native resources, and your app will get the `1.2.3` version number! +When running `tns prepare ...` the hooks will take care of the native resources. + +On iOS, your `Info.plist` will get: + +``` +CFBundleShortVersionString +1.2.3 +CFBundleVersion +1 +``` + +On Android, `AndroidManifest.xml` will have: + +``` + { + const platformData = platformsData.getPlatformData(platform); + if (platform == 'android') { + const manifest = new AndroidManifest().readFile(platformData.configurationFilePath); - // transforms e.g. "1.2.3" into 1002003. - var versionCode = appVersion.split('.').reduce((acc, v, i, a) => { - return acc + v * Math.pow(10, (a.length - i - 1) * 3); - }, 0); + // transforms e.g. "1.2.3" into 1002003. + let versionCode = appVersion + .split('.') + .reduce( + (acc, v, i, a) => + acc + v * Math.pow(10, (a.length - i - 1) * 2), + 0 + ); - manifest.$('manifest').attr('android:versionCode', versionCode); - manifest.$('manifest').attr('android:versionName', appVersion); - manifest.writeFile(platformData.configurationFilePath); - } else if (platform == 'ios') { - var plist = iOSPList.parse(fs.readFileSync(platformData.configurationFilePath, 'utf8')); - plist.CFBundleShortVersionString = appVersion; - plist.CFBundleVersion = appVersion; - fs.writeFileSync(platformData.configurationFilePath, iOSPList.build(plist)); - } - }); + if (appVersionNumber) { + versionCode = versionCode * 100 + appVersionNumber; + } + + manifest.$('manifest').attr('android:versionCode', versionCode); + manifest.$('manifest').attr('android:versionName', appVersion); + manifest.writeFile(platformData.configurationFilePath); + } else if (platform == 'ios') { + if (!appVersionNumber) { + appVersionNumber = appVersion; + } + const plist = iOSPList.parse(fs.readFileSync(platformData.configurationFilePath, 'utf8')); + plist.CFBundleShortVersionString = appVersion; + plist.CFBundleVersion = appVersionNumber; + fs.writeFileSync( + platformData.configurationFilePath, + iOSPList.build(plist) + ); + } + } + ); }; From 113c770378d2dc7a7dd76bf659528494a1a4bac4 Mon Sep 17 00:00:00 2001 From: Tiago Alves Date: Wed, 31 Jul 2019 16:16:11 +0100 Subject: [PATCH 5/9] Fix for NS 6. --- lib/after-prepare.js | 102 +++++++++++++++++++++++++------------------ 1 file changed, 59 insertions(+), 43 deletions(-) diff --git a/lib/after-prepare.js b/lib/after-prepare.js index 7ab74d7..e0fb5dd 100644 --- a/lib/after-prepare.js +++ b/lib/after-prepare.js @@ -1,57 +1,73 @@ -const fs = require('fs'); -const Promise = require('bluebird'); -const AndroidManifest = require('androidmanifest'); -const iOSPList = require('plist'); +var fs = require('fs'); +var AndroidManifest = require('androidmanifest'); +var iOSPList = require('plist'); -module.exports = function dev($logger, $projectData) { - const appPackage = require($projectData.projectFilePath); - const appVersion = +module.exports = function($logger, $projectData, hookArgs) { + var appPackage = require($projectData.projectFilePath); + var appVersion = (appPackage.nativescript && appPackage.nativescript.version) || appPackage.version; let appVersionNumber = (appPackage.nativescript && appPackage.nativescript.versionNumber) || appPackage.versionNumber; if (!appVersion) { - $logger.warn('Nativescript version is not defined. Skipping set native package version.'); + $logger.warn( + 'Nativescript version is not defined. Skipping set native package version.' + ); return; } - const platformService = $injector.resolve('platformService'); - const platformsData = $injector.resolve('platformsData'); - return Promise.each( - platformService.getPreparedPlatforms($projectData), - (platform) => { - const platformData = platformsData.getPlatformData(platform); - if (platform == 'android') { - const manifest = new AndroidManifest().readFile(platformData.configurationFilePath); - // transforms e.g. "1.2.3" into 1002003. - let versionCode = appVersion - .split('.') - .reduce( - (acc, v, i, a) => - acc + v * Math.pow(10, (a.length - i - 1) * 2), - 0 - ); + var platformsData = getPlatformsData($injector); + var platform = ( + hookArgs.platform || + (hookArgs.prepareData && hookArgs.prepareData.platform) + ).toLowerCase(); + $logger.info(`Platform: ${platform}`); - if (appVersionNumber) { - versionCode = versionCode * 100 + appVersionNumber; - } + var platformData = platformsData.getPlatformData(platform); + $logger.info( + `platformData.configurationFilePath: ${ + platformData.configurationFilePath + }` + ); + if (platform == 'android') { + var manifest = new AndroidManifest().readFile( + platformData.configurationFilePath + ); + + // transforms e.g. "1.2.3" into 102003. + let versionCode = appVersion + .split('.') + .reduce( + (acc, v, i, a) => + acc + v * Math.pow(10, (a.length - i - 1) * 2), + 0 + ); - manifest.$('manifest').attr('android:versionCode', versionCode); - manifest.$('manifest').attr('android:versionName', appVersion); - manifest.writeFile(platformData.configurationFilePath); - } else if (platform == 'ios') { - if (!appVersionNumber) { - appVersionNumber = appVersion; - } - const plist = iOSPList.parse(fs.readFileSync(platformData.configurationFilePath, 'utf8')); - plist.CFBundleShortVersionString = appVersion; - plist.CFBundleVersion = appVersionNumber; - fs.writeFileSync( - platformData.configurationFilePath, - iOSPList.build(plist) - ); - } + if (appVersionNumber) { + versionCode = versionCode * 100 + appVersionNumber; } - ); + + manifest.$('manifest').attr('android:versionCode', versionCode); + manifest.$('manifest').attr('android:versionName', appVersion); + manifest.writeFile(platformData.configurationFilePath); + } else if (platform == 'ios') { + var plist = iOSPList.parse( + fs.readFileSync(platformData.configurationFilePath, 'utf8') + ); + plist.CFBundleShortVersionString = appVersion; + plist.CFBundleVersion = appVersionNumber; + fs.writeFileSync( + platformData.configurationFilePath, + iOSPList.build(plist) + ); + } }; + +function getPlatformsData($injector) { + try { + return $injector.resolve('platformsData'); + } catch (err) { + return $injector.resolve('platformsDataService'); + } +} From 77d456370c7045e2060102898e95a044f4e994ad Mon Sep 17 00:00:00 2001 From: Tiago Alves Date: Wed, 31 Jul 2019 16:17:42 +0100 Subject: [PATCH 6/9] Update README and package.json. --- README.md | 2 ++ package.json | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index d64d86b..d82c2d2 100644 --- a/README.md +++ b/README.md @@ -4,6 +4,8 @@ This plugin takes the `version` and `versionNumber` properties from `package.jso This plugin is mainly a fork of [jacargentina/nativescript-dev-version](https://github.com/jacargentina/nativescript-dev-version), with the great ideas from [speigg/nativescript-dev-version](https://github.com/speigg/nativescript-dev-version/tree/patch-1) and [simplec-dev/nativescript-dev-version](https://github.com/simplec-dev/nativescript-dev-version). +Compatible with NS 6. + ## How to use ``` diff --git a/package.json b/package.json index cfed91a..158c627 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "nativescript-dev-version", - "version": "0.1.1", + "version": "0.2.0", "description": "Installs nativescript hooks to maintain native app version (AndroidManifest.xml and Info.plist)'", "main": "index.js", "scripts": { @@ -21,7 +21,6 @@ }, "dependencies": { "androidmanifest": "^2.0.0", - "bluebird": "^3.4.7", "nativescript-hook": "^0.2.1", "plist": "^2.0.1" } From 16a507e682b3f687e0fda2a474303f2ff8033cc4 Mon Sep 17 00:00:00 2001 From: Tiago Alves Date: Fri, 21 Feb 2020 18:56:11 +0000 Subject: [PATCH 7/9] Fixed versionCode padding bug. --- lib/after-prepare.js | 113 +++++++++++++++++++++---------------------- package.json | 2 +- 2 files changed, 56 insertions(+), 59 deletions(-) diff --git a/lib/after-prepare.js b/lib/after-prepare.js index e0fb5dd..d5370e2 100644 --- a/lib/after-prepare.js +++ b/lib/after-prepare.js @@ -3,71 +3,68 @@ var AndroidManifest = require('androidmanifest'); var iOSPList = require('plist'); module.exports = function($logger, $projectData, hookArgs) { - var appPackage = require($projectData.projectFilePath); - var appVersion = - (appPackage.nativescript && appPackage.nativescript.version) || - appPackage.version; - let appVersionNumber = - (appPackage.nativescript && appPackage.nativescript.versionNumber) || - appPackage.versionNumber; - if (!appVersion) { - $logger.warn( - 'Nativescript version is not defined. Skipping set native package version.' - ); - return; - } + var appPackage = require($projectData.projectFilePath); + var appVersion = + (appPackage.nativescript && appPackage.nativescript.version) || + appPackage.version; + let appVersionNumber = + (appPackage.nativescript && appPackage.nativescript.versionNumber) || + appPackage.versionNumber; + if (!appVersion) { + $logger.warn( + 'Nativescript version is not defined. Skipping set native package version.' + ); + return; + } - var platformsData = getPlatformsData($injector); - var platform = ( - hookArgs.platform || - (hookArgs.prepareData && hookArgs.prepareData.platform) - ).toLowerCase(); - $logger.info(`Platform: ${platform}`); + var platformsData = getPlatformsData($injector); + var platform = ( + hookArgs.platform || + (hookArgs.prepareData && hookArgs.prepareData.platform) + ).toLowerCase(); + $logger.info(`Platform: ${platform}`); - var platformData = platformsData.getPlatformData(platform); - $logger.info( - `platformData.configurationFilePath: ${ - platformData.configurationFilePath - }` + var platformData = platformsData.getPlatformData(platform); + $logger.info( + `platformData.configurationFilePath: ${platformData.configurationFilePath}` + ); + if (platform == 'android') { + var manifest = new AndroidManifest().readFile( + platformData.configurationFilePath ); - if (platform == 'android') { - var manifest = new AndroidManifest().readFile( - platformData.configurationFilePath - ); - - // transforms e.g. "1.2.3" into 102003. - let versionCode = appVersion - .split('.') - .reduce( - (acc, v, i, a) => - acc + v * Math.pow(10, (a.length - i - 1) * 2), - 0 - ); - if (appVersionNumber) { - versionCode = versionCode * 100 + appVersionNumber; - } + // transforms e.g. "1.2.3" into 102003. + let versionCode = appVersion + .split('.') + .reduce( + (acc, v, i, a) => acc + v * Math.pow(10, (a.length - i - 1) * 2), + 0 + ); - manifest.$('manifest').attr('android:versionCode', versionCode); - manifest.$('manifest').attr('android:versionName', appVersion); - manifest.writeFile(platformData.configurationFilePath); - } else if (platform == 'ios') { - var plist = iOSPList.parse( - fs.readFileSync(platformData.configurationFilePath, 'utf8') - ); - plist.CFBundleShortVersionString = appVersion; - plist.CFBundleVersion = appVersionNumber; - fs.writeFileSync( - platformData.configurationFilePath, - iOSPList.build(plist) - ); + if (appVersionNumber) { + versionCode = + versionCode * 100 + + (appVersionNumber < 10 ? '0' : '') + // left pad appVersionNumber + appVersionNumber; } + + manifest.$('manifest').attr('android:versionCode', versionCode); + manifest.$('manifest').attr('android:versionName', appVersion); + manifest.writeFile(platformData.configurationFilePath); + } else if (platform == 'ios') { + var plist = iOSPList.parse( + fs.readFileSync(platformData.configurationFilePath, 'utf8') + ); + plist.CFBundleShortVersionString = appVersion; + plist.CFBundleVersion = appVersionNumber; + fs.writeFileSync(platformData.configurationFilePath, iOSPList.build(plist)); + } }; function getPlatformsData($injector) { - try { - return $injector.resolve('platformsData'); - } catch (err) { - return $injector.resolve('platformsDataService'); - } + try { + return $injector.resolve('platformsData'); + } catch (err) { + return $injector.resolve('platformsDataService'); + } } diff --git a/package.json b/package.json index 158c627..fe03789 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "nativescript-dev-version", - "version": "0.2.0", + "version": "0.2.1", "description": "Installs nativescript hooks to maintain native app version (AndroidManifest.xml and Info.plist)'", "main": "index.js", "scripts": { From 96494802c27d313566791af9b65219ed1536b9b3 Mon Sep 17 00:00:00 2001 From: Tiago Alves Date: Tue, 23 Feb 2021 19:05:15 +0000 Subject: [PATCH 8/9] Fix for {N} 7+. --- lib/after-prepare.js | 12 +++++++----- package.json | 2 +- postinstall.js | 2 +- preuninstall.js | 2 +- 4 files changed, 10 insertions(+), 8 deletions(-) diff --git a/lib/after-prepare.js b/lib/after-prepare.js index d5370e2..c1e896c 100644 --- a/lib/after-prepare.js +++ b/lib/after-prepare.js @@ -25,7 +25,7 @@ module.exports = function($logger, $projectData, hookArgs) { $logger.info(`Platform: ${platform}`); var platformData = platformsData.getPlatformData(platform); - $logger.info( + $logger.debug( `platformData.configurationFilePath: ${platformData.configurationFilePath}` ); if (platform == 'android') { @@ -51,13 +51,15 @@ module.exports = function($logger, $projectData, hookArgs) { manifest.$('manifest').attr('android:versionCode', versionCode); manifest.$('manifest').attr('android:versionName', appVersion); manifest.writeFile(platformData.configurationFilePath); + $logger.info(`Updated android:versionCode: ${versionCode}, android:versionName: ${appVersion}`); } else if (platform == 'ios') { var plist = iOSPList.parse( fs.readFileSync(platformData.configurationFilePath, 'utf8') - ); - plist.CFBundleShortVersionString = appVersion; - plist.CFBundleVersion = appVersionNumber; - fs.writeFileSync(platformData.configurationFilePath, iOSPList.build(plist)); + ); + plist.CFBundleShortVersionString = appVersion; + plist.CFBundleVersion = appVersionNumber; + fs.writeFileSync(platformData.configurationFilePath, iOSPList.build(plist)); + $logger.info(`Updated CFBundleShortVersionString: ${appVersion}, CFBundleVersion: ${appVersionNumber}`); } }; diff --git a/package.json b/package.json index fe03789..652ee7a 100644 --- a/package.json +++ b/package.json @@ -20,8 +20,8 @@ ] }, "dependencies": { + "@nativescript/hook": "~2.0.0", "androidmanifest": "^2.0.0", - "nativescript-hook": "^0.2.1", "plist": "^2.0.1" } } diff --git a/postinstall.js b/postinstall.js index 12a6403..f55236d 100644 --- a/postinstall.js +++ b/postinstall.js @@ -1 +1 @@ -require('nativescript-hook')(__dirname).postinstall(); \ No newline at end of file +require('@nativescript/hook')(__dirname).postinstall(); \ No newline at end of file diff --git a/preuninstall.js b/preuninstall.js index b72ac69..3c292e1 100644 --- a/preuninstall.js +++ b/preuninstall.js @@ -1 +1 @@ -require('nativescript-hook')(__dirname).preuninstall(); +require('@nativescript/hook')(__dirname).preuninstall(); From 93571991daec79f67d469c1c2e6292689919b7f7 Mon Sep 17 00:00:00 2001 From: Tiago Alves Date: Tue, 21 Feb 2023 16:04:12 +0000 Subject: [PATCH 9/9] Update README.md --- README.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index d82c2d2..3bd6290 100644 --- a/README.md +++ b/README.md @@ -40,6 +40,15 @@ or: When running `tns prepare ...` the hooks will take care of the native resources. + +> **Warning** +> Remove/comment the lines in your `App_Resources/Android/app.gradle`: +> ``` +> // Version Information +> // versionCode 1 +> // versionName "1.0.0" +> ``` + On iOS, your `Info.plist` will get: ``` @@ -54,4 +63,4 @@ On Android, `AndroidManifest.xml` will have: ```