Skip to content

Conversation

@gustawdaniel
Copy link
Contributor

@gustawdaniel gustawdaniel commented Mar 25, 2023

#15

@spence-s
Copy link
Owner

Thanks for the PR! looks good. Should I go ahead and bump npm version and publish this? This looks like a minor version bump to me but not sure. -- I'll wait for a response here before publishing.

@spence-s spence-s merged commit 20f4d82 into spence-s:master Mar 25, 2023
@gustawdaniel
Copy link
Contributor Author

I now working on typescript implementation and esm + cjs format.

So I propose to publish it as minor version and soon we can publish major with breaking change in import. The same like uid that was imported by

import uid from 'uid';

but now is imported like

import {uid} from 'uid';

I hope that with typescript I will be able to close more issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants