Fix file/directory name case#650
Merged
spencermountain merged 1 commit intoDec 18, 2019
Merged
Conversation
The code references don't always match the actual filenames in case. For example, `./src/index.js` refers to `./World/World`, but the actual path is `./world/World(.js)`. This may work on macOS and Windows (which are case-insensitive by default), but not on Linux or on other case-sensitive systems. This PR renames the files/directories based on what appears to be their canonical names (based on the source references and other directories). Only two files (`scripts/pack.js` and `src/Doc/methods/output/_debug.js`) needed to be updated/edited to work with the new names. Running `npm test` now succeeds 100% with no error messages on my system (WSL/ext4 on Windows), once I'd `npm install`'d in all of the plugin directories. Fixes spencermountain#649
Contributor
Author
|
FWIW, |
JaredReisinger
added a commit
to JaredReisinger/compromise
that referenced
this pull request
Dec 17, 2019
… handling a greedy match. When handling a greedy match that's anchored to the start (`^`) or end (`$`), it is acceptable (normal, in fact!) for some of the matched terms to **not** be the first or last term in the phrase. This fix attempts to allow that without accidentally forgetting that the greedy match as a whole should still either start or end the document. Fixing this caused the `Doc.verbs()` behavior at https://github.com/spencermountain/compromise/blob/master/src/Subset/verbs/index.js#L15-L16 to change slightly (and correctly, I'd argue), such that a small change was needed at https://github.com/spencermountain/compromise/blob/master/src/Subset/verbs/methods.js#L45 (and on line 50) to compensate. Added a test to specifically check for the anchored-greedy-match case. (Note that this was fixed assuming PR spencermountain#650, so that I could run the tests.) Fixes spencermountain#648
Owner
|
ahh, thank you Jared. Just got back from vacation, will look at this this afternoon. |
Owner
|
thank you! |
Drache93
pushed a commit
to Drache93/compromise
that referenced
this pull request
Jan 6, 2020
… handling a greedy match. When handling a greedy match that's anchored to the start (`^`) or end (`$`), it is acceptable (normal, in fact!) for some of the matched terms to **not** be the first or last term in the phrase. This fix attempts to allow that without accidentally forgetting that the greedy match as a whole should still either start or end the document. Fixing this caused the `Doc.verbs()` behavior at https://github.com/spencermountain/compromise/blob/master/src/Subset/verbs/index.js#L15-L16 to change slightly (and correctly, I'd argue), such that a small change was needed at https://github.com/spencermountain/compromise/blob/master/src/Subset/verbs/methods.js#L45 (and on line 50) to compensate. Added a test to specifically check for the anchored-greedy-match case. (Note that this was fixed assuming PR spencermountain#650, so that I could run the tests.) Fixes spencermountain#648
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code references don't always match the actual filenames in case. For example,
./src/index.jsrefers to./World/World, but the actual path is./world/World(.js). This may work on macOS and Windows (which are case-insensitive by default), but not on Linux or on other case-sensitive systems.This PR renames the files/directories based on what appears to be their canonical names (based on the source references and other directories). Only two files (
scripts/pack.jsandsrc/Doc/methods/output/_debug.js) needed to be updated/edited to work with the new names.Running
npm testnow succeeds 100% with no error messages on my system (WSL/ext4 on Windows), once I'dnpm install'd in all of the plugin directories.Fixes #649