Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-pass GitHub Actions workflow for building/testing compromise #679

Merged
merged 3 commits into from Jan 24, 2020

Conversation

JaredReisinger
Copy link
Contributor

@JaredReisinger JaredReisinger commented Jan 23, 2020

This is an attempt at a very basic build/test workflow for GitHub Actions that can be triggered on any push (to master, or any branches or PRs). The set of tests run may be excessive, as it wasn't clear to me what the difference between the various tests listed in scripts in pacakge.json meant.

In addtion, some missing devDependencies (eslint, nlp-corpus, nyc, tap-spec, ts-node, and typescript) have been added to ensure that the tests can all run (even if they aren't all passing at the moment).

Finally, a new scripts/plugins.js was added to perform arbitrary commands for each plugin. The hope is that scripts/plugin-check.js can eventually be deprecated and replaced by (for example) npm run plugins:build.

This is an attempt at a very basic build/test workflow for GitHub Actions that can be triggered on any push (to master, or any branches or PRs).  The set of tests run may be excessive, as it wasn't clear to me what the difference between the various tests listed in `scripts` in `pacakge.json` meant.

In addtion, some missing devDependencies (eslint, nyc, tap-spec, ts-node, and typescript) have been added to ensure that the tests can all run (even if they aren't all passing at the moment).

Finally, a new `scripts/plugins.js` was added to perform arbitrary commands for each plugin.  The hope is that `scripts/plugin-check.js` can eventually be deprecated and replaced by (for example) `npm run plugins:build`.
@JaredReisinger JaredReisinger changed the title First-pass GitHub Actions workflow for building/testing compromise First-pass GitHub Actions workflow for building/testing compromise [WIP] Jan 23, 2020
@JaredReisinger
Copy link
Contributor Author

JaredReisinger commented Jan 23, 2020

Hey, @spencermountain ... just found out that the GitHub actions will run in my fork. Let me vet them there before you merge this! (I'll remove the [WIP] tag and comment once it's actually ready...)

@JaredReisinger JaredReisinger changed the title First-pass GitHub Actions workflow for building/testing compromise [WIP] First-pass GitHub Actions workflow for building/testing compromise Jan 24, 2020
@JaredReisinger
Copy link
Contributor Author

JaredReisinger commented Jan 24, 2020

Okay.... here's where this stands: at present, the workflow passes as long as npm run test, npm run test:spec, npm run test:speed, and npx nyc tape ./tests/**/*.test.js are all commented out. I believe that all of these other than test:speed are failing from the same underlying test. The speed test appears to (a) expect to be run on node 10.x, and (b) modifies a file that's not .gitignore'd (to persist the last-known-speed, I think).

With the caveat that there may be changes in dev that need testing tweaks before the basic tests can be included, I think this is "runnable" by default in the compromise repo. At the very least, it should be possible to include this in parallel with the Travis CI pipeline that already in place. Because of the way GitHub Actions work, merely including .github/workflows/... files will cause them to get triggered and run.

@spencermountain
Copy link
Owner

spencermountain commented Jan 24, 2020

YESSSSSSS
thank you Jared, this is terrific.

@spencermountain spencermountain merged commit 9138862 into spencermountain:dev Jan 24, 2020
1 check passed
@JaredReisinger JaredReisinger deleted the gh-actions branch Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants