New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSV import to the 1.9 branch #283

Closed
wants to merge 1 commit into
base: 1.9
from

Conversation

Projects
None yet
2 participants
@harningt
Copy link

harningt commented Sep 4, 2013

Here is the CSV import as mentioned in the thread: https://bitcointalk.org/index.php?topic=100502.620

It can accept either a CSV file or CSV entered into a text box. The rough format is:

"ADDRESS", 0.12345
"ADDRESS", 0.12314

No headers processed.

It will create the unsigned transaction (with default fees) and use the transaction signing dialog to permit signature signing.

@ecdsa

This comment has been minimized.

Copy link

ecdsa commented on ec75a13 Sep 4, 2013

Setting self.wallet.seed to None is ugly.
In addition, this will not work with bip32 wallets; you probably tested it with an old wallet.
it would be better to change the semantics of wallet.mktx(), so that it does not call tx.sign(), or does it optionally

This comment has been minimized.

Copy link

ecdsa replied Sep 4, 2013

ok, please see wallet.make_unsigned_transaction()

@ecdsa

This comment has been minimized.

Copy link
Member

ecdsa commented Sep 4, 2013

thanks; please see comment. I might merge it later after I work out mktx()

@ecdsa

This comment has been minimized.

Copy link
Member

ecdsa commented Sep 4, 2013

done

@ecdsa ecdsa closed this Sep 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment