Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bip84 for sw seeds #3630

Merged
merged 2 commits into from
Jan 11, 2018
Merged

bip84 for sw seeds #3630

merged 2 commits into from
Jan 11, 2018

Conversation

SomberNight
Copy link
Member

@SomberNight SomberNight commented Dec 31, 2017

This enables software bip39 seeds to use p2wpkh scripts to receive on along the derivation path described in soon-to-be bip84: bitcoin/bips#620

Best not to merge until bip84 gets into draft status (above PR gets merged).
EDIT: bip84 is now in draft status


For the time being I've disabled this (p2wpkh output scripts for receiving) for hardware wallets.

  • The Trezor plugin needs some changes for it to work, but the fw might be ready. bech32 with Trezor #3551
  • Ledger (Nano S) seems to work already with btchip-python 0.1.24, and latest fw
  • KeepKey and dbb are not ready for this (though I haven't tested)
    • KeepKey needs changes in plugin, but even before that, I think python-keepkey needs some changes (and their fw too)
    • not sure about dbb but the respective plugin, again, would at least need changes

Hence, the most reasonable path forward would be to get Trezor to work ( #3551 ), and then test Trezor and Ledger a bit more, before enabling this for them. (This PR can get merged before that though.)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 42.945% when pulling e218c4a on SomberNight:bip84 into a95534b on spesmilo:master.

@SomberNight SomberNight mentioned this pull request Dec 31, 2017
@prusnak
Copy link
Contributor

prusnak commented Jan 4, 2018

BIP84 has been merged into the BIPS repo: https://github.com/bitcoin/bips/blob/master/bip-0084.mediawiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants