Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables software bip39 seeds to use p2wpkh scripts to receive on along the derivation path described in soon-to-be bip84: bitcoin/bips#620
Best not to merge until bip84 gets into draft status (above PR gets merged).EDIT: bip84 is now in draft status
For the time being I've disabled this (p2wpkh output scripts for receiving) for hardware wallets.
Hence, the most reasonable path forward would be to get Trezor to work ( #3551 ), and then test Trezor and Ledger a bit more, before enabling this for them. (This PR can get merged before that though.)