New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a warning about harmful code to the Qt console #3700
Conversation
43230a7
to
7f74d21
Compare
|
Thanks for testing! I didn't find a way to automatically increase the size of the label based on the content size. However, I've enabled word wrapping and increased the height slightly so it should be at least better now. |
|
Yep, it fits now in both these cases, thanks. :) |
|
do we want the hidden state to be remembered? |
|
Not sure about that. The console is seldom used so the benefit wouldn't be big. |
|
No. People forget. I don’t mind that Facebook always greets me with a huge DONT PASTE STUFF HERE message. As long as it doesn’t cover up server banners I say persist for the session until the GUI is closed |
|
@ecdsa Do you mean clicking it once would hide it forever? It's very easy to click it even by mistake. @dabura667 Well it covers up server banners somewhat (now more than on above screenshots). But I think the behaviour in the PR of "click it once, and it won't be shown until you re-open Electrum" is fine. |




This adds a warning about malicious code to the console window. It should help prevent users from executing code they found online.
Screenshots
This warning is certainly hard to miss:

Clicking the message indeed hides it:

Related: #3678