Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give visual feedback while starting #4997

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
4 participants
@sajolida
Copy link
Contributor

commented Jan 9, 2019

I'm working for Tails (https://tails.boum.org/), a privacy-oriented
Linux distribution which includes XXX.

While doing usability testing for Tails or getting feedback from
users, we realized how important it was to give feedback very quickly
after the user chooses to start an application. The usual mechanism
for this in GNOME is to change the mouse cursor into a spinner as soon
as the user chooses the application from a menu or from the activities
overview.

For example, we've seen time after time people opening the same
application several times when its launcher lacked this feedback.

XXX doesn't provide this feedback but I think it's easy to fix.

Even when an application usually starts fast, there might be some
circumstances when it will be a bit slower to start (live operating
systems like Tails is one of them but it might happen on any busy
system).

The Freedesktop specification for such feedback is to uses a
combination of StartupNotify and StartupWMClass.

See https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html

@bauerj

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

What is XXX?

@ecdsa

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

I guess XXX is 'Electrum' . The message with this PR might be a generic message, posted on all projects that do not implement StartupNotify

@sajolida

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2019

Hey! Indeed, I sent PR to several projects included in Tails and forgot to edit my template properly.

I fixed this now in the text. We use a lot of Git at Tails but never GitHub :)

Sorry for the confusion!

@bauerj

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

No worries, I'm all for working efficiently!

I validated the file with desktop-file-validate so it seems like the syntax is correct. Can anyone test this?

@SomberNight

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

I've tried to test this but could not notice any difference.
I think the spinner does not show up as the application process starts very fast (even though in some cases the GUI window takes some time to appear) -- is there supposed to be a spinner while the window is not visible?

Looking at the spec, the change looks okay; and based on this askubuntu thread, StartupWMClass also seems ok (note that when running from source it's actually run_electrum but in that case you wouldn't use the .desktop launcher I guess).

In any case, I think we can merge this.

@SomberNight SomberNight merged commit 889d133 into spesmilo:master Jan 25, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 50.57%
Details
@ecdsa

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

I also could not notice any difference. I guess merging was ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.