Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting in IOFS.ReadDir #372

Merged
merged 1 commit into from Jul 19, 2022
Merged

Fix sorting in IOFS.ReadDir #372

merged 1 commit into from Jul 19, 2022

Conversation

bep
Copy link
Collaborator

@bep bep commented Jul 19, 2022

We recently added a check for fs.ReadDirFile in IOFS.ReadDir, but forgot to apply a sort to the
result as defined in the spec.

This fixes that and adds a test case for it.

We recently added a check for fs.ReadDirFile in IOFS.ReadDir, but forgot to apply a sort to the
result as defined in the spec.

This fixes that and adds a test case for it.
@bep bep merged commit 0aa65ed into spf13:master Jul 19, 2022
11 checks passed
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Jul 27, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/spf13/afero](https://togithub.com/spf13/afero) | require | patch | `v1.9.0` -> `v1.9.2` |

---

### Release Notes

<details>
<summary>spf13/afero</summary>

### [`v1.9.2`](https://togithub.com/spf13/afero/releases/tag/v1.9.2)

[Compare Source](https://togithub.com/spf13/afero/compare/v1.9.1...v1.9.2)

#### What's Changed

-   Make mem.File implement fs.ReadDirFile by [@&#8203;bep](https://togithub.com/bep) in [spf13/afero#371

**Full Changelog**: spf13/afero@v1.9.1...v1.9.2

### [`v1.9.1`](https://togithub.com/spf13/afero/releases/tag/v1.9.1)

[Compare Source](https://togithub.com/spf13/afero/compare/v1.9.0...v1.9.1)

#### What's Changed

-   Fix sorting in IOFS.ReadDir by [@&#8203;bep](https://togithub.com/bep) in [spf13/afero#372

**Full Changelog**: spf13/afero@v1.9.0...v1.9.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzEuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzMS4xIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant