refactor: mv cmd/* ./

[umarcor]

See #8.

[marckhouzam]

Since the cobra-cli uses cobra, isn't nice that it follows the same layout as other programs using cobra?

[umarcor]

@marckhouzam do other programs using cobra have the main function of the CLI separated from all the files defining the commands of the same CLI? I believe this PR makes cobra-cli more consistent with how it's used in practice. See, for instance:

• https://github.com/helm/helm/tree/main/cmd/helm
  • https://github.com/helm/helm/blob/main/cmd/helm/helm.go#L58
• https://github.com/docker/cli
  • https://github.com/docker/cli/blob/master/cmd/docker/docker.go#L250

[marckhouzam]

@marckhouzam do other programs using cobra have the main function of the CLI separated from all the files defining the commands of the same CLI? I believe this PR makes cobra-cli more consistent with how it's used in practice.

You are right about the main.go. I was more curious about the cmd subdir? All the Cobra programs I've seen use it:

• https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/kubectl/pkg/cmd
• https://github.com/helm/helm/tree/main/cmd
• https://github.com/docker/cli/tree/master/cmd
• https://github.com/k3d-io/k3d/tree/main/cmd
• https://github.com/cli/cli/tree/trunk/pkg/cmd

[umarcor]

I believe the main reasons for all of those projects to use a cmd are:

• Repos do contain additional content.
• None of the users are expected to install the tools through go install. End-users can download pre-built executables for their platforms, or use their favourite package manager.

However, in the case of cobra, it was decided to move the CLI to a separated repo (context: spf13/cobra#1240 and spf13/cobra#1597), rather than managing it as done in helm, docker, k3d, gh... and AFAIAA pre-built executables were never provided (spf13/cobra#976 (comment)). Hence, having cmd/cobra-cli in this repo would be weird, because users would need to use go install github.com/spf13/cobra-cli/cmd/cobra-cli@latest. This PR preserves go install github.com/spf13/cobra-cli@latest.

Moreover, in the case of helm and docker, I believe that the cmd subdir is unnecessary. Particularly, I think they misunderstood the structure that cobra was using. It was cobra/cmd, not cmd/cobra. That is cmd should have not been in the path used for building the executable. Now, mv cmd/helm ./ and mv cmd/docker ./ should have no impact at all (apart from adjusting the imports/build commands). See spf13/cobra#1430.

[github-actions]

This PR is being marked as stale due to a long period of inactivity

[andreaangiolillo]

Hello 👋

Maybe we can consider the layout described here https://github.com/golang-standards/project-layout

• cmd/
  • cobracli/
    • cobracli.go (package main)
• internal/
  • add.go
  • ......

[github-actions]

This PR is being marked as stale due to a long period of inactivity

[umarcor]

@marckhouzam @jpmcb maybe we should remove the stale bot in this repo as well?

Refs: spf13/cobra#1858, spf13/cobra#1908, spf13/cobra#1910

[github-actions]

This PR is being marked as stale due to a long period of inactivity