Duplicate output - probably in error cases

[jensklose]

Versions

go version go1.16.4 linux/amd64
cobra 1.1.3

How to reproduce?

Generate a new project with cobra init --pkg-name doublecheck.
Generate a new command with cobra add version.
Build the project or use go run.

Output

>go run main.go version
version called

> go run main.go vrsion
Error: unknown command "vrsion" for "doublecheck"

Did you mean this?
        version

Run 'doublecheck --help' for usage.
Error: unknown command "vrsion" for "doublecheck"

Did you mean this?
        version

exit status 1

Test with unknown command:

go run main.go foo
Error: unknown command "foo" for "doublecheck"
Run 'terrasec --help' for usage.
Error: unknown command "foo" for "doublecheck"
exit status 1

Expected behavior

No double messages

[afbagwell]

We are observing this behavior as well with a bare-bones setup for a new CLI app my team is working on.

using
go1.15.12 linux/amd64
cobra 1.2.1

More info:
Duplication is occurring not only on typos as reported above but also if RunE throws an error. The pattern is similar:

Error: [error msg]

[Usage info]

[error msg]

It's as if whatever method or template is being used in both cases is accidentally calling the error string a second time.

[ANGkeith]

func Execute() {
	cobra.CheckErr(rootCmd.Execute())
}

removing the cobra.CheckErr() fix the duplicated error message for me

func Execute() {
	rootCmd.Execute()
}

resulting in:

Error: [error msg]
[Usage info]

but the program exits with status code 0, and i use this to fix reflect the correct exit status code

func Execute() {
	err := rootCmd.Execute()
	if err != nil {
		os.Exit(1)
	}
}

[github-actions]

This issue is being marked as stale due to a long period of inactivity