Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change so help is printed on stdout again #1004

Merged
merged 1 commit into from Dec 23, 2019

Conversation

marckhouzam
Copy link
Collaborator

@marckhouzam marckhouzam commented Dec 22, 2019

Fixes #1002
For backwards compatibility reasons, and to follow the need of
kubernetes/kubernetes#26077 (comment)
the help message should be printed on stdout.

/cc @bruceadowns @bogem @jharshman

Fixes spf13#1002
For backwards compatibility reasons, and to follow the need of
kubernetes/kubernetes#26077 (comment)
the help message should be printed on stdout.

Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
@jharshman
Copy link
Collaborator

@jharshman jharshman commented Dec 23, 2019

@marckhouzam, since @bogem was the one who merged #922, I am going to give him a chance to weigh in here.

@jharshman jharshman added this to the 1.0.0 milestone Dec 23, 2019
@jharshman jharshman added the kind/bug label Dec 23, 2019
@jharshman jharshman requested a review from bogem Dec 23, 2019
@eparis
Copy link
Collaborator

@eparis eparis commented Dec 23, 2019

I completely agree. Help, especially when requested by the user, belong on stdout.

@eparis eparis merged commit 0d9d2d4 into spf13:master Dec 23, 2019
5 checks passed
@marckhouzam marckhouzam deleted the fix/revertStderr branch Dec 23, 2019
marckhouzam pushed a commit to VilledeMontreal/acceptance-testing that referenced this issue Jan 1, 2020
This reverts commit 187a774.

Cobra has reverted the change that had the help message go to stderr:
spf13/cobra#1004

Considering what allowed to notice this regression in Cobra was the
failure of Helm's acceptance-testing repo, I prefer to continue have
the test fail if the help ever goes to stderr.
marckhouzam pushed a commit to VilledeMontreal/acceptance-testing that referenced this issue Jan 1, 2020
This reverts commit 187a774.

Cobra has reverted the change that had the help message go to stderr:
spf13/cobra#1004

Considering what allowed to notice this regression in Cobra was the
failure of Helm's acceptance-testing repo, I prefer to continue have
the test fail if the help ever goes to stderr.

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam pushed a commit to helm/acceptance-testing that referenced this issue Feb 2, 2020
This reverts commit 187a774.

Cobra has reverted the change that had the help message go to stderr:
spf13/cobra#1004

Considering what allowed to notice this regression in Cobra was the
failure of Helm's acceptance-testing repo, I prefer to continue have
the test fail if the help ever goes to stderr.

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants