Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small correction in README #1009

Merged
merged 1 commit into from Nov 15, 2021
Merged

Small correction in README #1009

merged 1 commit into from Nov 15, 2021

Conversation

nickolashkraus
Copy link
Contributor

@nickolashkraus nickolashkraus commented Jan 1, 2020

I thought this sentence seemed off:

Note, that the variable author will not be set to the value from config, when the --author flag is not provided by user.

In the Viper documentation:

Viper uses the following precedence order. Each item takes precedence over the item below it:

  • explicit call to Set
  • flag
  • env
  • config
  • key/value store
  • default

One would assume that:

...the variable author will not be set to the value from config, when the --author flag is provided by user.

Testing with cobra init bears this out:

cobra init --pkg-name test

/*
Copyright © 2020 Nickolas Kraus

*/

cobra init --pkg-name test --author Me

/*
Copyright © 2020 Me

*/

umarcor
umarcor approved these changes Jan 3, 2020
Copy link
Contributor

@umarcor umarcor left a comment

I think that the second commit should be a separate PR, but both of them are ok.

@nickolashkraus
Copy link
Contributor Author

nickolashkraus commented Jan 3, 2020

@umarcor Removed 8994876. #1010 now contains year bump.

@umarcor
Copy link
Contributor

umarcor commented Jan 4, 2020

@nickolashkraus, thanks! That allowed to rebase many other PRs that failed because of the year.


Request to include this PR in 1.0.0. Ref #959.

umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 4, 2020
@nickolashkraus
Copy link
Contributor Author

nickolashkraus commented Jan 6, 2020

@umarcor Anything else required from me on this PR?

@umarcor
Copy link
Contributor

umarcor commented Jan 6, 2020

@umarcor Anything else required from me on this PR?

Now that #1010 is merged, you can either rebase or just wait until someone with write access picks it.

umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 6, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 3, 2020
@umarcor umarcor mentioned this pull request Feb 3, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 20, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 1, 2020
@CLAassistant
Copy link

CLAassistant commented Mar 6, 2020

CLA assistant check
All committers have signed the CLA.

@jharshman jharshman added the kind/documentation Documentation of cobra itself label Mar 30, 2020
@jharshman jharshman modified the milestone: 1.0.0 Mar 30, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Apr 13, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
@github-actions
Copy link

github-actions bot commented May 30, 2020

This PR is being marked as stale due to a long period of inactivity

umarcor pushed a commit to umarcor/cobra that referenced this pull request Jul 4, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jul 11, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jul 13, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Sep 25, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Oct 1, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Oct 14, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Oct 18, 2020
@umarcor umarcor mentioned this pull request Jun 29, 2021
Copy link
Collaborator

@jpmcb jpmcb left a comment

Hi @nickolashkraus - thank you so much for the contribution!!

Looks like there is a conflict in the readme. Can you update and I'll get this in ASAP?

@jpmcb
Copy link
Collaborator

jpmcb commented Nov 2, 2021

Hi @nickolashkraus - any chance we can get an update from you on this? Otherwise, I'll close this and open an issue to address this - thanks much

@nickolashkraus
Copy link
Contributor Author

nickolashkraus commented Nov 2, 2021

@jpmcb Sorry I missed your original message! Rebased and addressed merge conflicts

umarcor
umarcor approved these changes Nov 2, 2021
umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 5, 2021
@jpmcb jpmcb merged commit 3c84bf8 into spf13:master Nov 15, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Documentation of cobra itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants