Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for autolabel stale PR #1075

Merged
merged 4 commits into from Apr 2, 2020
Merged

Conversation

xchapter7x
Copy link
Contributor

automatically labels stale PRs

automatically labels stale PRs
@CLAassistant
Copy link

CLAassistant commented Apr 1, 2020

CLA assistant check
All committers have signed the CLA.

@xchapter7x
Copy link
Contributor Author

@jharshman

@jharshman jharshman added the kind/feature A feature request for cobra; new or enhanced behavior label Apr 1, 2020
@jharshman
Copy link
Collaborator

Will this just apply the stale label or also close the issue?

@xchapter7x
Copy link
Contributor Author

Will this just apply the stale label or also close the issue?

@jharshman

For now this is just adding labels. We can, I believe, modify that later to auto-close things.

updates the stale label to reflect
existing project labels
@jharshman
Copy link
Collaborator

For now this is just adding labels. We can, I believe, modify that later to auto-close things.

Okay great - step in the right direction. This will give us an ability to prioritize combing through some of the stale issues and either create action items or close them out.

@wfernandes
Copy link
Collaborator

I had a question about the default behavior and found my answer so I thought I'd share it here:

This github action runs midnight every day to mark issues as stale. By default if the issue/PR has no activity for 60 days it will mark it as stale and if it remains stale for another week it then closes the issue/PR automatically. More info: https://github.com/actions/stale

@xchapter7x
Copy link
Contributor Author

I had a question about the default behavior and found my answer so I thought I'd share it here:

This github action runs midnight every day to mark issues as stale. By default if the issue/PR has no activity for 60 days it will mark it as stale and if it remains stale for another week it then closes the issue/PR automatically. More info: https://github.com/actions/stale

@wfernandes thanks for detailing the behavior. I was mistaken when I said it wouldnt close the issues. Great catch.

I guess the question for @jharshman, is the behavior described by @wfernandes desired?

If not we can modify the config such that issues/prs do not get auto-closed.

for both PRs and issues there is now a more
descriptive and relevant message
when the action marks something stale
@jharshman
Copy link
Collaborator

@xchapter7x

If not we can modify the config such that issues/prs do not get auto-closed.

Yes let's do that so they don't auto-close. There are some issues that I know are stale but are still relevant.

@xchapter7x
Copy link
Contributor Author

@xchapter7x

If not we can modify the config such that issues/prs do not get auto-closed.

Yes let's do that so they don't auto-close. There are some issues that I know are stale but are still relevant.

@jharshman
there are 2 general ways. We can add an exempt label, which would allow us to filter the stale items we do not want auto-closed.
or
we can just make nothing get auto-closed via a really long config ie days-before-close: 999999

thoughts on which workflow you'd prefer?

uses the exempt flag to ignore issues already marked
stale. this will allow us to auto label stale,
and then ignore them so they do not get auto
closed.
@xchapter7x
Copy link
Contributor Author

@jharshman
where i landed for the implementation is i created an exempt label, which matches the stale label.
This way, once the issues/prs are labelled stale by the action, they will from then on be ignored by the action and will not be auto-closed.

moving forward we can simply change or remove the exempt label to support our desired workflow in auto-closing or not.

@jharshman
Copy link
Collaborator

@xchapter7x sounds like a plan. Lmk if I need to create a new label.

@xchapter7x
Copy link
Contributor Author

xchapter7x commented Apr 2, 2020

@xchapter7x sounds like a plan. Lmk if I need to create a new label.

@jharshman
the only label this action uses is kind/stale. as long as that exists we should be fine.

@jharshman jharshman merged commit 138b98f into spf13:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request for cobra; new or enhanced behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants