Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Man pages won't have auto gen tag when option is disabled #1104

Merged
merged 4 commits into from Apr 29, 2020

Conversation

jpmcb
Copy link
Collaborator

@jpmcb jpmcb commented Apr 25, 2020

This addresses #741

When cmd.DisableAutoGenTag = true, the man pages will no longer contain Auto generated by spf13/cobra

Let me know if this needs anything else!

@jharshman jharshman added the kind/feature A feature request for cobra; new or enhanced behavior label Apr 28, 2020
@jpmcb
Copy link
Collaborator Author

jpmcb commented Apr 29, 2020

I've added documentation for this in a new file docs/README.md which will also be viewable in Github when a user views the docs/ folder in their browser.

I've also added a changelog in a new file CHANGELOG.md which includes the v1.0.0 changes and captures this PRs new behavior in a Pending section. This should enable the maintainers to easily track changes, make releases, and request that contributors document their changes.

If the CHANGELOG.md file is out of scope for this PR, I can remove it, let me know!

@jpmcb jpmcb requested a review from jharshman Apr 29, 2020
@jharshman jharshman merged commit e392f32 into spf13:master Apr 29, 2020
2 of 3 checks passed
@jpmcb jpmcb deleted the disable-update branch Apr 29, 2020
alexeagle added a commit to aspect-build/aspect-cli that referenced this pull request Oct 1, 2021
alexeagle added a commit to aspect-build/aspect-cli that referenced this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request for cobra; new or enhanced behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants