Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fish output redirection #1247

Merged
merged 1 commit into from Oct 6, 2020
Merged

fix: fish output redirection #1247

merged 1 commit into from Oct 6, 2020

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Oct 5, 2020

resolves #1246

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2020

CLA assistant check
All committers have signed the CLA.

@marckhouzam
Copy link
Collaborator

marckhouzam commented Oct 5, 2020

Thanks @matejvasek, to make sure we don't break this again, could you put a comment not to use &> because Fish 3.0 does not support it?

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

matejvasek commented Oct 5, 2020

@marckhouzam comment added.

Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Thanks.
I've tested this with Fish 3.1 and things continue to work as expected.

@jharshman this looks safe.

Copy link
Collaborator

@jharshman jharshman left a comment

thank you @matejvasek for your PR and @marckhouzam for your review!

@jharshman jharshman merged commit b97b5ea into spf13:master Oct 6, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fish completion error
4 participants