Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add GitHub Actions workflow 'Test' #1339

Merged
merged 4 commits into from Feb 9, 2021
Merged

ci: add GitHub Actions workflow 'Test' #1339

merged 4 commits into from Feb 9, 2021

Conversation

@umarcor
Copy link
Contributor

@umarcor umarcor commented Feb 8, 2021

Travis changed their pricing model. Free resources for open source projects were significantly reduced, and maintainers need to periodically request additional "credits". Since this projects is in spf13's namespace, I guess that only he can see the state of the credits.

In practice, most open source projects are migrating from Travis CI to somewhere else, mostly GitHub Actions.

Refs: #952 #968 #1044 #1075 #1074 #1143 #1323 #1338

@umarcor umarcor mentioned this pull request Feb 8, 2021
Copy link
Collaborator

@jpmcb jpmcb left a comment

Looks like you beat me to it 😆 #1340

I think we can combine our efforts. And looks like yours is much more robust (and has the latest linting PR that got merged). Although I would like to see some changes:

.github/workflows/Test.yml Outdated Show resolved Hide resolved
.github/workflows/Test.yml Outdated Show resolved Hide resolved
.github/workflows/Test.yml Outdated Show resolved Hide resolved
.github/workflows/Test.yml Outdated Show resolved Hide resolved
@umarcor umarcor force-pushed the ci/actions branch 2 times, most recently from e08c4ec to 2b4d7cf Feb 9, 2021
jpmcb
jpmcb approved these changes Feb 9, 2021
Copy link
Collaborator

@jpmcb jpmcb left a comment

Looks great! I'll merge this and we'll run both Travis CI and Github Actions side by side for now. Once we're fully confident, we can remove Travis all together!

Thanks for the changes and the thoughtful work you put into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants